1156662 - Identical code for different branches in nsStructuredCloneContainer.cpp

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

Bug 1154366 updated some of the code of nsStructuredCloneContainer.cpp

Now, we have same code in 
nsresult nsStructuredCloneContainer::InitFromJSVal
cid 1295227

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: bug-1156662.diff

I know that you don't do review but it landed recently and it landed in m-b.
(I wonder if it does not hide something).

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8595199 [details] [diff] [review]
bug-1156662.diff

Oh, oops.  Yeah, this branching can totally go away.

No need for that temporary false either.  Just do:

   bool success = JS_WriteStructuredClone(aCx, aData, &jsBytes, &mSize,
                                          nullptr, nullptr,
                                          JS::UndefinedHandleValue);

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Attachment: 240214.diff

here it is, thanks

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b9a594d013bd

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b9a594d013bd