Closed Bug 1156691 Opened 5 years ago Closed 5 years ago

GUI "Edit filters": Conditions/actions (for specfic accounts) not visible

Categories

(MailNews Core :: Filters, defect)

defect
Not set

Tracking

(thunderbird38 fixed, thunderbird39 fixed, thunderbird40 fixed)

RESOLVED FIXED
Thunderbird 40.0
Tracking Status
thunderbird38 --- fixed
thunderbird39 --- fixed
thunderbird40 --- fixed

People

(Reporter: ralf-123, Assigned: aceman)

Details

Attachments

(2 files)

Attached image 2015-04-21_11h15_01.png
User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/43.0.2357.18 Safari/537.36

Steps to reproduce:

Editing or creating filter rules for account abc@def.ghi opens "edit filter" dialogue window - this is broken
Please note:
Issue does _not_ apply to filter rules for "local folders". This works correctly.


Actual results:

When editing existing filter rules or creating a new filter rule, the "edit filter" GUI does not show any conditions & actions neither options to create any.
Existing filters, although they seem to have no conditions nor actions, still work correctly as before - but can't by modified (not even the name of the rule is shown)
IIRC, issue occurred first with beta 37


Expected results:

GUI elements to add/remove/edit conditions and actions as well as the actual conditions&actions should be displayed.
Yeah, something is broken there. After you see this empty dialog, can you go into tools->error console and see if there are any errors or warnings? Please paste them here.

Then try in Thunderbird's safe mode (Help->restart with addons disabled) and check the filter editor again.
Hi,

Error log:

Error: TypeError: this.checkboxOutgoing is undefined
Source: chrome://messenger/content/FilterEditor.js
Line: 332

Safe mode (w/o addons) does change it - same problem
Great, that's the problem. I see where the error is in the code.
Assignee: nobody → acelists
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
OS: Unspecified → All
Product: Thunderbird → MailNews Core
Hardware: Unspecified → All
Attached patch patchSplinter Review
This should be it.
Attachment #8595516 - Flags: review?(rkent)
Comment on attachment 8595516 [details] [diff] [review]
patch

LGTM.
Attachment #8595516 - Flags: review?(rkent)
Attachment #8595516 - Flags: review+
Attachment #8595516 - Flags: approval-comm-beta?
Attachment #8595516 - Flags: approval-comm-aurora?
Thanks.
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/aab4c3d92cd7
Keywords: checkin-needed
Target Milestone: --- → Thunderbird 40.0
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.