Closed
Bug 1156691
Opened 9 years ago
Closed 9 years ago
GUI "Edit filters": Conditions/actions (for specfic accounts) not visible
Categories
(MailNews Core :: Filters, defect)
Tracking
(thunderbird38 fixed, thunderbird39 fixed, thunderbird40 fixed)
RESOLVED
FIXED
Thunderbird 40.0
People
(Reporter: ralf-123, Assigned: aceman)
Details
Attachments
(2 files)
13.40 KB,
image/png
|
Details | |
935 bytes,
patch
|
rkent
:
review+
rkent
:
approval-comm-aurora+
rkent
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/43.0.2357.18 Safari/537.36 Steps to reproduce: Editing or creating filter rules for account abc@def.ghi opens "edit filter" dialogue window - this is broken Please note: Issue does _not_ apply to filter rules for "local folders". This works correctly. Actual results: When editing existing filter rules or creating a new filter rule, the "edit filter" GUI does not show any conditions & actions neither options to create any. Existing filters, although they seem to have no conditions nor actions, still work correctly as before - but can't by modified (not even the name of the rule is shown) IIRC, issue occurred first with beta 37 Expected results: GUI elements to add/remove/edit conditions and actions as well as the actual conditions&actions should be displayed.
Yeah, something is broken there. After you see this empty dialog, can you go into tools->error console and see if there are any errors or warnings? Please paste them here. Then try in Thunderbird's safe mode (Help->restart with addons disabled) and check the filter editor again.
Hi, Error log: Error: TypeError: this.checkboxOutgoing is undefined Source: chrome://messenger/content/FilterEditor.js Line: 332 Safe mode (w/o addons) does change it - same problem
Great, that's the problem. I see where the error is in the code.
Assignee: nobody → acelists
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
OS: Unspecified → All
Product: Thunderbird → MailNews Core
Hardware: Unspecified → All
This should be it.
Attachment #8595516 -
Flags: review?(rkent)
status-thunderbird38:
--- → affected
tracking-thunderbird38:
--- → ?
Comment 5•9 years ago
|
||
Comment on attachment 8595516 [details] [diff] [review] patch LGTM.
Attachment #8595516 -
Flags: review?(rkent)
Attachment #8595516 -
Flags: review+
Attachment #8595516 -
Flags: approval-comm-beta?
Attachment #8595516 -
Flags: approval-comm-aurora?
Comment 7•9 years ago
|
||
https://hg.mozilla.org/comm-central/rev/aab4c3d92cd7
Keywords: checkin-needed
Target Milestone: --- → Thunderbird 40.0
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment 8•9 years ago
|
||
Comment on attachment 8595516 [details] [diff] [review] patch http://hg.mozilla.org/releases/comm-aurora/rev/bf2dfc259a66 http://hg.mozilla.org/releases/comm-beta/rev/98df258b09d0
Attachment #8595516 -
Flags: approval-comm-beta?
Attachment #8595516 -
Flags: approval-comm-beta+
Attachment #8595516 -
Flags: approval-comm-aurora?
Attachment #8595516 -
Flags: approval-comm-aurora+
Updated•9 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•