1156691 - GUI "Edit filters": Conditions/actions (for specfic accounts) not visible

Status: RESOLVED FIXED

(MailNews Core :: Filters, defect)

Description

[Ralf]

Attachment: 2015-04-21_11h15_01.png

User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/43.0.2357.18 Safari/537.36

Steps to reproduce:

Editing or creating filter rules for account [e-mail] opens "edit filter" dialogue window - this is broken
Please note:
Issue does _not_ apply to filter rules for "local folders". This works correctly.


Actual results:

When editing existing filter rules or creating a new filter rule, the "edit filter" GUI does not show any conditions & actions neither options to create any.
Existing filters, although they seem to have no conditions nor actions, still work correctly as before - but can't by modified (not even the name of the rule is shown)
IIRC, issue occurred first with beta 37


Expected results:

GUI elements to add/remove/edit conditions and actions as well as the actual conditions&actions should be displayed.

Comment 1

[:aceman]

Yeah, something is broken there. After you see this empty dialog, can you go into tools->error console and see if there are any errors or warnings? Please paste them here.

Then try in Thunderbird's safe mode (Help->restart with addons disabled) and check the filter editor again.

Comment 2

[Ralf]

Hi,

Error log:

Error: TypeError: this.checkboxOutgoing is undefined
Source: chrome://messenger/content/FilterEditor.js
Line: 332

Safe mode (w/o addons) does change it - same problem

Comment 3

[:aceman]

Great, that's the problem. I see where the error is in the code.

Comment 4

[:aceman]

Attachment: patch

This should be it.

Comment 5

[Kent James (:rkent)]

Comment on attachment 8595516 [details] [diff] [review]
patch

LGTM.

Comment 6

[:aceman]

Thanks.

Comment 7

[Magnus Melin [:mkmelin]]

https://hg.mozilla.org/comm-central/rev/aab4c3d92cd7

Comment 8

[Kent James (:rkent)]

Comment on attachment 8595516 [details] [diff] [review]
patch

http://hg.mozilla.org/releases/comm-aurora/rev/bf2dfc259a66
http://hg.mozilla.org/releases/comm-beta/rev/98df258b09d0