115670 - [FIX]Save As dialog displays filter twice for each file type

Status: VERIFIED FIXED

(Core Graveyard :: File Handling, defect, P1)

Description

[Leston Buell]

When you open a Save As dialog now, each entry in the "Files of Type" drop-down
displays the filter twice, like this:

   Web Page (complete) (*.htm; *.html) (*.htm; *.html) 
   Text File (*.txt) (*.txt)

What it should really look like is this:

   Web Page (complete) (*.htm; *.html)
   Text File (*.txt)

This is only the Save As dialog, not the Open dialog which has this bug.

I'm using Linux trunk build 2001-12-17-08. I'll attach a screenshot.

Comment 1

[Leston Buell]

Attachment: image of Save As dialog with bug

Comment 2

[jjkarppi]

Confirming this with Linux trunk build 2001-12-21-08. Moving to File handling.

Comment 3

[Bill Law]

->bryner

Brian, this is either a quirk in the Linux file picker, or something that's 
been fixed.  It doesn't show up in the Win32 file picker.

Comment 4

[Leston Buell]

It's not fixed. I still see it using Linux trunk build 2002-01-19-06.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: Proposed patch

Tested on Linux, needs testing on Win to make sure it doesn't break things...

Comment 6

[Boris Zbarsky [:bzbarsky]]

Got this tested on Win2k, and it works good over there too.  Reviews?

Comment 7

[Brian Ryner (not reading)]

Comment on attachment 66471 [details] [diff] [review]
Proposed patch

r=bryner

Comment 8

[jag (Peter Annema)]

Comment on attachment 66471 [details] [diff] [review]
Proposed patch

sr=jag

Comment 9

[Boris Zbarsky [:bzbarsky]]

Checked in.

Comment 10

[sairuh (rarely reading bugmail)]

vrfy'd fixed with 2002.07.23.06-1.0 comm branch bits on linux rh7.2.