115673 - offline:news:ui: need news icons for news megs that have been downloaded in classic theme

Status: VERIFIED FIXED

Description

[grylchan]

Similar to bug 67359 (mail icons for classic)
and bug 88970  (needed news icons for modern theme).

When news mesgs are downloaded for offline use, there is no
way to distinguish between news megs that have been downloaded
and ones that have not. We need this for classic theme.
Modern theme has their own news icons already. We would
need this for all platforms.


Shuehan, I don't know if this bug 86897 (people don't like
icons for modern theme) will affect you or not. Just pointing it
out, just in case.

Comment 1

[shliang]

Created attachment 65280 [details]
icons for classic

Comment 2

[shliang]

Created attachment 65281 [details]
icons for modern

Comment 3

[shliang]

Created attachment 65283 [details] [diff] [review]
css changes

also fixes bug 110551

Comment 4

[andreww]

Comment on attachment 65280 [details]
icons for classic

please fix the long filename for message-news-new-attach-offl.gi

Comment 5

[andreww]

Comment on attachment 65281 [details]
icons for modern

please fix the long filename for message-news-new-attach-offl.gi

Comment 6

[andreww]

Comment on attachment 65283 [details] [diff] [review]
css changes

looks ok - 
r=andreww provided you 
1) update those long image names  
2) dont forget to change the names also in the .css file

Comment 7

[Joe Hewitt (gone)]

Comment on attachment 65283 [details] [diff] [review]
css changes

sr=hewitt, but change outlinerbody to outlinerchildren

Comment 8

[shliang]

fixed

Comment 9

[Håkan Waara]

shliang, why are you always checking in as stephend? I wonder if this is such a
good idea.

Comment 10

[grylchan]

Shuehan,
Quick question: has this been checked into the trunk yet?

Using 2002-02-01-10-trunk/ nt 4.0 and 2002-02-01-03-trunk/ mac 9.1

I can't distinguish between downloaded/non-downloaded news mesgs
in classic theme. thnx.

Comment 11

[shliang]

hey gary - this was checked in but looking at it now the difference is hard to
see because the downloaded icons aren't dark enough, so i will do them over.
thanks for pointing that out. 

Comment 12

[grylchan]

reopening...

Comment 13

[shliang]

new icons checked in

Comment 14

[grylchan]

reopening again as per my conversation with Shuehan (Correct
me if I am wrong on this Shuehan).

Comment 15

[Asa Dotzler [:asa]]

Comment on attachment 65283 [details] [diff] [review]
css changes

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 16

[shliang]

fixed

Comment 17

[grylchan]

Using commercial trunk
2002031107 on mac 10.1.3
2002031108 on mac 9.2.2

Verified that news mesgs icons are different for downloaded/
non-downloaded news mesgs in classic theme.

Switching between themes results in the proper icon being displayed
for down/non-downloaded mesgs.

marking as verified.

Comment 18

[grylchan]

really marking as verified this time