1156754 - Pref-off the new animation-inspector UI v3 by default

Status: RESOLVED FIXED

(DevTools :: Inspector: Animations, defect)

Description

[Patrick Brosset <:pbro>]

Introduce a pref that will be used to develop the animation-inspector UI v3 (bug 1153271) while keeping the current UI as is.
I doubt that the new UI will be fully functional after one bug fix, so this pref would help smooth out the transition.

Comment 1

[Patrick Brosset <:pbro>]

The patch I'll attach here really just adds a pref to firefox.js, something along the lines of newUI=true/false.

The strategy here is that the new UI we want to put in place in bug 1153271 is sufficiently different from the current one that we can't migrate from one to the other, it has to be a switch over at some stage.

This pref will make it possible to both:
- develop the new UI hidden, allowing people to still use the current one, and try out the few bits of the new UI that will land if they want to
- create tests for the new UI, while making sure the existing ones still work.

Comment 2

[Patrick Brosset <:pbro>]

Attachment: MozReview Request: bz://1156754/pbrosset

/r/8697 - Bug 1156754 - Introduce a pref for the new animation inspector UI

Pull down this commit:

hg pull -r a510d1741570e51517672e9f054979709802b277 https://reviewboard-hg.mozilla.org/gecko/

Comment 3

[Patrick Brosset <:pbro>]

Joe, I wasn't sure who to ask for review for this (small) patch.
Let me know if you think the approach in comment 1 makes sense.

Comment 4

[Joe Walker [:jwalker]]

(In reply to Patrick Brosset [:pbrosset] [:patrick] from comment #3)
> Joe, I wasn't sure who to ask for review for this (small) patch.
> Let me know if you think the approach in comment 1 makes sense.

Yes makes sense to me.

Comment 5

[Patrick Brosset <:pbro>]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ef7171f9454b

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/1ef7c8593ae6

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1ef7c8593ae6

Comment 9

[Patrick Brosset <:pbro>]

Attachment: MozReview Request: Bug 1156754 - Introduce a pref for the new animation inspector UI