Pref-off the new animation-inspector UI v3 by default

RESOLVED FIXED in Firefox 41

Status

RESOLVED FIXED
4 years ago
3 months ago

People

(Reporter: pbro, Assigned: pbro)

Tracking

unspecified
Firefox 41
Dependency tree / graph

Firefox Tracking Flags

(firefox41 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
Introduce a pref that will be used to develop the animation-inspector UI v3 (bug 1153271) while keeping the current UI as is.
I doubt that the new UI will be fully functional after one bug fix, so this pref would help smooth out the transition.
(Assignee)

Updated

4 years ago
Blocks: 1153271
(Assignee)

Updated

4 years ago
Blocks: 1155663
(Assignee)

Updated

3 years ago
Assignee: nobody → pbrosset
(Assignee)

Comment 1

3 years ago
The patch I'll attach here really just adds a pref to firefox.js, something along the lines of newUI=true/false.

The strategy here is that the new UI we want to put in place in bug 1153271 is sufficiently different from the current one that we can't migrate from one to the other, it has to be a switch over at some stage.

This pref will make it possible to both:
- develop the new UI hidden, allowing people to still use the current one, and try out the few bits of the new UI that will land if they want to
- create tests for the new UI, while making sure the existing ones still work.
Status: NEW → ASSIGNED
(Assignee)

Comment 2

3 years ago
Created attachment 8605360 [details]
MozReview Request: bz://1156754/pbrosset

/r/8697 - Bug 1156754 - Introduce a pref for the new animation inspector UI

Pull down this commit:

hg pull -r a510d1741570e51517672e9f054979709802b277 https://reviewboard-hg.mozilla.org/gecko/
Attachment #8605360 - Flags: review?(jwalker)
(Assignee)

Comment 3

3 years ago
Joe, I wasn't sure who to ask for review for this (small) patch.
Let me know if you think the approach in comment 1 makes sense.
Attachment #8605360 - Flags: review?(jwalker) → review+
(In reply to Patrick Brosset [:pbrosset] [:patrick] from comment #3)
> Joe, I wasn't sure who to ask for review for this (small) patch.
> Let me know if you think the approach in comment 1 makes sense.

Yes makes sense to me.
https://hg.mozilla.org/mozilla-central/rev/1ef7c8593ae6
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
(Assignee)

Comment 8

3 years ago
Comment on attachment 8605360 [details]
MozReview Request: bz://1156754/pbrosset
Attachment #8605360 - Attachment is obsolete: true
Attachment #8620099 - Flags: review+
(Assignee)

Comment 9

3 years ago
Created attachment 8620099 [details]
MozReview Request: Bug 1156754 - Introduce a pref for the new animation inspector UI
(Assignee)

Updated

3 years ago
Component: Developer Tools: Inspector → Developer Tools: Animation Inspector

Updated

3 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.