Closed Bug 1156779 Opened 9 years ago Closed 6 years ago

[docker-worker] Do not silently fail when request feature does not exist

Categories

(Taskcluster :: Workers, defect, P2)

Product:
Taskcluster
Component:
Workers
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: garndt, Assigned: wcosta)

References

Details

(Whiteboard: [docker-worker]) 

When a feature is requested by a task that is not a supported feature within docker-worker, nothing gets logged or fails.  This could either by a typo of the feature name, using a worker-type that doesn't have the feature, etc.

Instead perhaps we should validate the requested features against the supported features and fail the task if there is an issue.  This way the task isn't assumed to have a feature available when it really doesn't.
Component: TaskCluster → Docker-Worker
Product: Testing → Taskcluster
Whiteboard: [docker-worker]
Component: Docker-Worker → Worker
Assignee: nobody → wcosta
Status: NEW → ASSIGNED
QA Contact: pmoore
Priority: -- → P2
Commit pushed to master at https://github.com/taskcluster/docker-worker

https://github.com/taskcluster/docker-worker/commit/ef11879ab3146c2df27670b27da336e64eb9e7d0
Bug 1156779: Fail the task if the payload contains an invalid feature

The current behavior is to run the task even if an invalid feature is
passed in the payload. We change this to fail the task if an invalid
feature is detected.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Component: Worker → Workers
You need to log in before you can comment on or make changes to this bug.