Closed Bug 1156781 Opened 6 years ago Closed 6 years ago

Pass --symbols-path into Mulet reftests

Categories

(Testing :: Reftest, defect)

defect
Not set
normal

Tracking

(firefox40 fixed)

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: ahal, Assigned: ahal)

References

Details

Attachments

(1 file, 1 obsolete file)

Looks like --symbols-path isn't being passed in for Mulet reftests:
https://dxr.mozilla.org/mozilla-central/source/testing/config/mozharness/linux_mulet_config.py
Attached file MozReview Request: bz://1156781/ahal (obsolete) —
/r/7357 - Bug 1156781 - Pass --symbols-path into Mulet reftests, r=gerard-majax

Pull down this commit:

hg pull -r 74556eed32a2f716b6afd31c4c843844d5c4b50e https://reviewboard-hg.mozilla.org/gecko/
Attachment #8595360 - Flags: review?(lissyx+mozillians)
Assignee: nobody → ahalberstadt
Status: NEW → ASSIGNED
Comment on attachment 8595360 [details]
MozReview Request: bz://1156781/ahal

I don't know if I should be considered as a valid peer, but it looks good to me :)
Attachment #8595360 - Flags: review?(lissyx+mozillians) → review+
Don't worry, it's a safe change and the I even did a try run that passes. The review was more of an fyi as you originally landed this file :).
https://hg.mozilla.org/mozilla-central/rev/b0b7eb86d115
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Attachment #8595360 - Attachment is obsolete: true
Attachment #8620101 - Flags: review+
Comment on attachment 8620101 [details]
MozReview Request: Bug 1156781 - Pass --symbols-path into Mulet reftests, r=gerard-majax

https://reviewboard.mozilla.org/r/7357/#review33407
Attachment #8620101 - Flags: review+
Comment on attachment 8620101 [details]
MozReview Request: Bug 1156781 - Pass --symbols-path into Mulet reftests, r=gerard-majax

https://reviewboard.mozilla.org/r/7357/#review33413
Attachment #8620101 - Flags: review+
You need to log in before you can comment on or make changes to this bug.