Closed Bug 1156882 Opened 9 years ago Closed 9 years ago

[mozilla-download] Add support for emulator-ics and emulator-kk

Categories

(Taskcluster :: General, defect)

Product:
Taskcluster
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: rwood, Assigned: rwood)

References

Details

Attachments

(1 file)

https://github.com/mozilla-b2g/mozilla-download/pull/24
56 bytes, text/x-github-pull-request
gaye
: review+
Details | Review 
rwood@ubuntu:~$ ./node_modules/.bin/mozilla-download /home/worker/emulator/ --branch mozilla-central --product emulator-ics
Error: Unknown product emulator-ics

Need to add emulator-ics and emulator-kk in moz_build_info.js.
Status: NEW → ASSIGNED
Comment on attachment 8595545 [details] [review]
https://github.com/mozilla-b2g/mozilla-download/pull/24

Comments on GH. Set flag again when ready for another pass.
Attachment #8595545 - Flags: review?(gaye)
Comment on attachment 8595545 [details] [review]
https://github.com/mozilla-b2g/mozilla-download/pull/24

Thanks for the review, PR updated
Attachment #8595545 - Flags: review?(gaye)
Comment on attachment 8595545 [details] [review]
https://github.com/mozilla-b2g/mozilla-download/pull/24

Did another pass. I think we're getting warmer but still not there
Attachment #8595545 - Flags: review?(gaye)
Comment on attachment 8595545 [details] [review]
https://github.com/mozilla-b2g/mozilla-download/pull/24

Thanks for your time Gareth, appreciated, PR updated
Attachment #8595545 - Flags: review?(gaye)
Comment on attachment 8595545 [details] [review]
https://github.com/mozilla-b2g/mozilla-download/pull/24

I have one last nit on GH but once that's fixed, this looks good. Thanks for hanging in there :)
Attachment #8595545 - Flags: review?(gaye) → review+
Thanks Gareth, fixed the nit and merged:

https://github.com/mozilla-b2g/mozilla-download/commit/7c265f1655acee3705c7553032112fbe8fde4d0f

Would you mind publishing a new npm package (or add me as an owner) when you get a chance? Thanks!
Flags: needinfo?(gaye)
Done.
Flags: needinfo?(gaye)
Thanks!
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Component: TaskCluster → General
Product: Testing → Taskcluster
Target Milestone: --- → mozilla41
Version: unspecified → Trunk
Resetting Version and Target Milestone that accidentally got changed...
Target Milestone: mozilla41 → ---
Version: Trunk → unspecified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: