1156911 - [Browser][RTL] Navigating to another URL in browser will shift the 'Search Bar' partway offscreen to the right

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect, P1)

Description

[Oliver Nelson [:oliverthor]]

Attachment: logcat_20150421_1157.txt

Description:
When a user is in an RTL language (Arabic) and they navigate from any single page in browser to another hyperlink (google -> site; kotaku -> story), they will observe the search bar shift right partyway off screen.

PreReq:
* WiFi or Data
Repro Steps:
1) Update a Flame to 20150421010201
2) Open browser
3) Open google search for 'bears'
4) Observe 'Search Bar' ** Expected
5) Tap first link for wiki page for 'bears
6) On load, observe 'Search Bar' ** Actual

Actual:
Search Bar shifts off screen to the right

Expected:
Search Bar is on screen


Environmental Variables:
--------------------------------------------------

Device: Flame 3.0
Build ID: 20150421010201
Gaia: a8e4f95dce9db727dda5d408b038f97fb4296557
Gecko: 7b823253d9f2
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 40.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

--------------------------------------------------

Issue DOES NOT REPRO on 2.2 for flame devices
Results: Search Bar is on screen

Device: Flame 2.2
BuildID: 20150421002501
Gaia: 828dd03a0e3b140d74b2e49355197df4d91d9227
Gecko: 36f72a3efb9b
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
--------------------------------------------------

Repro frequency: 5/5
See attached: 
screenshot
logcat

Comment 1

[Oliver Nelson [:oliverthor]]

Attachment: browser_searchbar_offscreen.png

Comment 2

[Delphine Lebédel]

Ouch.
Triage -- P1, nominating

Comment 3

[Peter Bylenga [:PBylenga]]

[Blocking Requested - why for this release]:
Functional regression of a supported feature.

Requesting a window.

Comment 4

[Yeojin Chung [:YeojinC]]

b2g-inbound Regression Window:

Last Working Environmental Variables:
Device: Flame 3.0
BuildID: 20150420102757
Gaia: c5adc3534fe2bdf32eb84c13f16513bc14cdae57
Gecko: 6400820a5efa
Version: 40.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

First Broken Environmental Variables:
Device: Flame 3.0
BuildID: 20150420115257
Gaia: 36d1a65e448539c0589b722c7b2e7ab2945e76dc
Gecko: 0f6870abd92b
Version: 40.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

Last Working Gaia First Broken Gecko: Issue does NOT reproduce 
Gaia: c5adc3534fe2bdf32eb84c13f16513bc14cdae57
Gecko: 6400820a5efa

First Broken Gaia Last Working Gecko: Issue DOES reproduce
Gaia: 36d1a65e448539c0589b722c7b2e7ab2945e76dc
Gecko: 0f6870abd92b

https://github.com/mozilla-b2g/gaia/compare/c5adc3534fe2bdf32eb84c13f16513bc14cdae57...36d1a65e448539c0589b722c7b2e7ab2945e76dc

Caused by bug 1056770

Comment 5

[KTucker [:KTucker][Inactive 3/4/2016]]

Alberto, can you take a look at this please? Looks like the landing for bug 1056770.

Comment 6

[Kevin Grandon :kgrandon]

Resolved now that bug 1056770 has been backed out.

Comment 7

[Sue]

Attachment: verified_pass.png

This issue has been verified passed on latest build of Flame 3.0 with the same steps in comment 0.
See attachment:verified_pass.png
Rate:0/5
Device: Flame 3.0 (pass)
Build ID               20150422160203
Gaia Revision          9d4f756aa35cb7f030a92f3c1f65fb55254ddd1d
Gaia Date              2015-04-22 17:32:36
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/a9311ec2dd39
Gecko Version          40.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150422.193515
Firmware Date          Wed Apr 22 19:35:27 EDT 2015
Bootloader             L1TC000118D0

--------------------------------------------------
This issue has been verified fail on Nexus 5 v3.0 with the same steps in comment 0.
See attachment:verified_fail_on_N5.png
Rate:3/3

Device: Nexus 5 3.0 (fail)
Build ID               20150422010202
Gaia Revision          15134b080b5f406e5aa36f5136c17dafb4e31f64
Gaia Date              2015-04-21 19:52:45
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/946ac85af8f4
Gecko Version          40.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150422.044004
Firmware Date          Wed Apr 22 04:40:22 EDT 2015
Bootloader             HHZ12f

Comment 8

[Sue]

Attachment: verified_fail_on_N5.png

Comment 9

[Sue]

Hi Josh,
Per comment 7, could you please help with it? Thanks! :)

Comment 10

[Josh Cheng [:josh]]

Hi Kevin,
The issue still exist on Nexus 5 3.0 per comment 7.
Could you please help to check it again?
Thanks!

Comment 11

[Kevin Grandon :kgrandon]

This is confusing because it was a regression, but now fixed on flame due to a backout.

I guess we should check *if* this is a regression for a nexus device - maybe it would never work on that? Can we verify that it's still broken on nexus, and that it's still a regression?

Perhaps a new nexus-5specific bug is needed?

Comment 12

[Sue]

Attachment: 2015-05-04-03-48-02.png

This issue do not exist on latest build of Nexus 5 3.0 with the same steps in comment 0.
Result: Search bar is shown correctly.
See attachment:2015-05-04-03-48-02.png
Rate: 0/5

Device: Nexus 5 3.0 (pass)
Build ID               20150503160200
Gaia Revision          e18cce173840d6ff07fb6f1f0e0ffb58b99aab3e
Gaia Date              2015-05-02 04:27:01
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/dc5f85980a82
Gecko Version          40.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150503.193953
Firmware Date          Sun May  3 19:40:11 EDT 2015
Bootloader             HHZ12f

Comment 13

[Sue]

I guess the patch does not land on the build "20150422010202" of Nexus 5 in comment 7. According to comment 7 and comment 12, this issue has been verified passed.