Closed Bug 1156935 Opened 9 years ago Closed 9 years ago

Perma-fail, test_a11y_screen_manager.py TestScreenManagerAccessibility.test_a11y_screen_manager | AssertionError: False is not true

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: kgrandon, Unassigned)

References

Details

Attachments

(1 file)

This test started failing suddenly:

15:21:04    ERROR -  TEST-UNEXPECTED-FAIL | test_a11y_screen_manager.py TestScreenManagerAccessibility.test_a11y_screen_manager | AssertionError: False is not true
15:21:04     INFO -  Traceback (most recent call last):
15:21:04     INFO -    File "/home/worker/build/venv/local/lib/python2.7/site-packages/marionette/marionette_test.py", line 296, in run
15:21:04     INFO -      testMethod()
15:21:04     INFO -    File "/home/worker/gaia/tests/python/gaia-ui-tests/gaiatest/tests/accessibility/system/test_a11y_screen_manager.py", line 44, in test_a11y_screen_manager
15:21:04     INFO -      self.assertTrue(self.device.is_screen_enabled)

Started failing here: https://treeherder.mozilla.org/#/jobs?repo=b2g-inbound&revision=f27313f6d86a
Disabled here while we investigate: https://github.com/mozilla-b2g/gaia/commit/15134b080b5f406e5aa36f5136c17dafb4e31f64

Some work has been done on this test to get this into shape here: https://gist.github.com/davehunt/295e36ad4df5225e9d5a

Need info on dave/yura to figure out what to do with this text next.
Flags: needinfo?(yzenevich)
Flags: needinfo?(dave.hunt)
(In reply to Kevin Grandon :kgrandon from comment #1)
> Disabled here while we investigate:
> https://github.com/mozilla-b2g/gaia/commit/
> 15134b080b5f406e5aa36f5136c17dafb4e31f64
> 
> Some work has been done on this test to get this into shape here:
> https://gist.github.com/davehunt/295e36ad4df5225e9d5a
> 
> Need info on dave/yura to figure out what to do with this text next.

From what I can tell the gist tests the right thing.
Flags: needinfo?(yzenevich)
Comment on attachment 8595923 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/29663

I managed to get this to pass by increasing the sleep timeout to be greater than the dim notice. It appears that the dim notice is subtracted from the sleep timeout regardless of that making the timeout 0 or negative. I wonder if Gaia should be changed to prevent this (and allowing shorter timeouts in our tests), however I doubt a user will ever encounter this.
Attachment #8595923 - Attachment description: [gaia] davehunt:bug1156935 > mozilla-b2g:master → Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/29663
Flags: needinfo?(dave.hunt)
Attachment #8595923 - Flags: review?(yzenevich)
Comment on attachment 8595923 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/29663

Looks good thanks!
Attachment #8595923 - Flags: review?(yzenevich) → review+
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Blocks: 1147731
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: