Closed Bug 1156939 Opened 8 years ago Closed 8 years ago

Intermittent browser_bug710878.js | Test timed out | Found a tab

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Version:
38 Branch
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 40
Tracking Flags:
Tracking Status
e10s + ---
firefox38 --- fixed
firefox38.0.5 --- fixed
firefox39 --- fixed
firefox40 --- fixed
firefox-esr31 --- unaffected

People

(Reporter: RyanVM, Assigned: mrbkap)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Possible patch
1.41 KB, patch
mconley
: review+
Details | Diff | Splinter Review 
tracking-e10s? given the dead CPOW

08:07:02 INFO - 311 INFO TEST-START | browser/base/content/test/general/browser_bug710878.js
08:07:04 INFO - JavaScript error: , line 0: Error: operation not possible on dead CPOW
08:07:48 INFO - Xlib: extension "RANDR" missing on display ":0".
08:07:49 INFO - TEST-INFO | screentopng: exit 0
08:07:49 INFO - 312 INFO checking window state
08:07:49 INFO - 313 INFO Console message: [JavaScript Error: "The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol." {file: "data:text/html,<a%20href='%23xxx'><span>word1%20<span>%20word2%20</span></span><span>%20word3</span></a>" line: 0}]
08:07:49 INFO - 314 INFO Console message: [JavaScript Error: "Error: operation not possible on dead CPOW"]
08:07:49 INFO - 315 INFO TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_bug710878.js | Test timed out - expected PASS
08:07:49 INFO - MEMORY STAT vsize after test: 21991796043776
08:07:49 INFO - MEMORY STAT residentFast after test: 647815168
08:07:49 INFO - 316 INFO TEST-OK | browser/base/content/test/general/browser_bug710878.js | took 45198ms
08:07:49 INFO - 317 INFO TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_bug710878.js | Found a tab after previous test timed out: data:text/html,<a%20href='%23xxx'><span>word1%20<span>%20word2%20</span></span><span>%20word3</span></a> - expected PASS
Attached patch Possible patch — — Splinter Review 
I glanced at the testcase here and there might be a really simple fix.  We grab a reference to a CPOW and then wait for focus. However, in the meantime, nothing stops us from collecting the CPOW out from under us.  This patch reduces the amount of time that we need the CPOW alive for, which should hopefully stop this bug from reoccuring.

While I was here, I took the opportunity to silence a "no charset declared" warning.
Attachment #8596148 - Flags: review?(mconley)
Comment on attachment 8596148 [details] [diff] [review]
Possible patch

Review of attachment 8596148 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine to me, thanks Blake.
Attachment #8596148 - Flags: review?(mconley) → review+
Assignee: nobody → mrbkap
https://hg.mozilla.org/mozilla-central/rev/50f6cd646a8e
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
You need to log in before you can comment on or make changes to this bug.