Closed Bug 1156952 Opened 5 years ago Closed 5 years ago

Try to switch fennec over to using the "attached" widget listener model

Categories

(Core :: Widget: Android, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: kats, Assigned: kats)

Details

Attachments

(1 file, 1 obsolete file)

Basically, in Fennec we have two nsWindow instances getting created - a root window and a child window. Bug 1155186 did some cleanup in this regard but we are still having issues in that GetViewFor(nsIWidget*) when called on the root window doesn't return the right nsView. After talking with tn [1] it seems like we should be able to use the "attached widget listener" model used in linux and windows to get rid of one of our nsWindow instances (the child one) and have its widget listener registered as the mAttachedWidgetListener for the parent window. This might simplify a lot of things which would be really nice.

Filing this bug to explore this possibility.

[1] See IRC conversation starting at http://logs.glob.uno/?c=mozilla%23apz&s=21%20Apr%202015&e=21%20Apr%202015#c6070 (interleaved with other conversations, sorry)
Attached patch Better WIPSplinter Review
Now with more stuff removed.
Attachment #8595534 - Attachment is obsolete: true
The try build is green, I'll run with it for a few days to make sure there's no obvious problems.
Assignee: nobody → bugmail.mozilla
Comment on attachment 8595556 [details] [diff] [review]
Better WIP

Review of attachment 8595556 [details] [diff] [review]:
-----------------------------------------------------------------

Been running with the build for a day now and haven't seen any issues. Although if we back out the hiddenwindow removal this patch may need changes, so we should probably figure that out first.
Attachment #8595556 - Flags: review?(snorp)
Comment on attachment 8595556 [details] [diff] [review]
Better WIP

Review of attachment 8595556 [details] [diff] [review]:
-----------------------------------------------------------------

woooo
Attachment #8595556 - Flags: review?(snorp) → review+
I did a try push on top of the hidden window backout, it's green: https://treeherder.mozilla.org/#/jobs?repo=try&revision=52489751558a and running it locally also shows no obvious problems. However I'll wait until tomorrow to land it because I want to have at least one nightly generated with the hiddenwindow backout so we can more easily tell if this breaks addons again or not.
https://hg.mozilla.org/mozilla-central/rev/670c8cf8b473
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.