1156963 - [E-Mail] Signature Field is scrollable with no characters, looks jumpy with a single line

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Oliver Nelson [:oliverthor]]

Attachment: logcat_20150421_1336.txt

Description:
When a user is editting the signature field of their e-mail from within the E-Mail app -> Account Settings, they will observe that the text field that they edit in is scrollable when there is no characters input. This produces the effect of a scrollbar which is unnecessary, and when combined with limited characters appears odd as the user can shift the screen around.

Repro Steps:
1) Update a Flame to 20150421010201
2) Open the E-Mail app
3) Sign in to an account
4) Navigate to account settings (top-left Drawer -> bottom Gear -> Select account)
5) Tap signature field to edit
6) Scroll text field **
7) Erase signature and scroll field **

Actual:
Signature field is scrollable and produces oddlooking UI

Expected:
Signature field is not scrollable when there is limited text


Environmental Variables:
--------------------------------------------------

Device: Flame 3.0
Build ID: 20150421010201
Gaia: a8e4f95dce9db727dda5d408b038f97fb4296557
Gecko: 7b823253d9f2
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 40.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

Device: Flame 2.2
BuildID: 20150421002501
Gaia: 828dd03a0e3b140d74b2e49355197df4d91d9227
Gecko: 36f72a3efb9b
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Device: Flame 2.1
BuildID: 20150421001205
Gaia: bbe983b4e8bebfec26b3726b79568a22d667223c
Gecko: b85d4f4a6d61
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 34.0 (2.1) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
--------------------------------------------------

E-Mail has different behavior in 2.0 for flame devices
Results: User does not have a modifiable signature field

Device: Flame 2.0
BuildID: 20150421000202
Gaia: 84898cadf28b1a1fcd03b726cff658de470282f0
Gecko: c17fa8ed09c7
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 32.0 (2.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0
--------------------------------------------------


Repro frequency: 5/5
See attached: 
video- https://youtu.be/Ti3XNr1OClU
logcat

Comment 1

[Peter Bylenga [:PBylenga]]

NI component owner for nomination decision and assignment, not a regression.

Comment 2

[Teri Wen [:twen]]

Although it's a minor issue, scroll-bar is unnecessary and creates odd user experience. 
Nominate for future work.

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] jrburke:bug1156963-email-conteneditable-scroll > mozilla-b2g:master

Comment 4

[James Burke [:jrburke]]

Comment on attachment 8596005 [details] [review]
[gaia] jrburke:bug1156963-email-conteneditable-scroll > mozilla-b2g:master

The issue was the padding for the contenteditable area pushed that box outside the sizing it was given to fit on the page. The fix is easy, just a box-sizing: border-box to make sure the padding is considered for the box size.

The contenteditable in the compose does not need this as the containing box in that page is the scrolling one, not the contenteditable box. So just this signature area needs the adjustment.

Comment 5

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/8a241ba6b71a90f48529738da156695afd8ff51b

Comment 6

[helen（leave from Mozilla）]

Attachment: v3.0.mp4

This bug has been verified as pass on latest build of Flame v3.0 & Nexus 5 v3.0 by the STR in Comment 0. 

Results:
Signature field is not scrollable when there is limited or no text.

See attachment: v3.0.mp4
Reproduce rate: 0/10

Device: Flame v3.0(Pass)
Build ID               20150601160204
Gaia Revision          6d477a7884273886605049b20f60af5c1583a150
Gaia Date              2015-06-01 16:41:42
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/56241c1f8a3b
Gecko Version          41.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150601.193935
Firmware Date          Mon Jun  1 19:39:44 EDT 2015
Bootloader             L1TC000118D0

Device: Nexus 5 v3.0(Pass)
Build ID               20150601075320
Gaia Revision          85e6fcef45c0cb2c017739df42b68b96cf5bb9c3
Gaia Date              2015-06-01 06:40:19
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/666b584fb521
Gecko Version          41.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150601.112653
Firmware Date          Mon Jun  1 11:27:09 EDT 2015
Bootloader             HHZ12f