1156987 - Extract devtools event-emitter.js to toolkit

Status: RESOLVED DUPLICATE of bug 1356231

(Toolkit :: General, defect)

Description

[David Teller [:Yoric] - still alive but not very active]

At the moment, our only mechanism for observer notifications is nsIObserverService. It is useful, but it has a number drawbacks:
- it is easy to get the topic wrong;
- it is clearly not designed to let us put a JS object in a notification;
- error-handling is non-existent.

We could easily implement a mechanism that would not have these drawbacks.

As a first application, I would like to make it simple to [un]subscribe to AddonWatcher notifications.

Comment 1

[David Teller [:Yoric] - still alive but not very active]

Attachment: MozReview Request: bz://1156987/Yoric

/r/7413 - Bug 1156987 - Simple event mechanism

Pull down this commit:

hg pull -r 28d73a46637fcc3e1d0bbb45dea5314615f336ef https://reviewboard-hg.mozilla.org/gecko/

Comment 2

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 8595622 [details]
MozReview Request: bz://1156987/Yoric

/r/7413 - Bug 1156987 - Simple event mechanism

Pull down this commit:

hg pull -r 28d73a46637fcc3e1d0bbb45dea5314615f336ef https://reviewboard-hg.mozilla.org/gecko/

Comment 3

[David Teller [:Yoric] - still alive but not very active]

https://reviewboard.mozilla.org/r/7411/#review6175

Note that this is actually a f? rather than a r?.

Comment 4

[Dave Townsend [:mossop]]

Comment on attachment 8595622 [details]
MozReview Request: bz://1156987/Yoric

https://reviewboard.mozilla.org/r/7411/#review6179

Comment 5

[Dave Townsend [:mossop]]

Comment on attachment 8595622 [details]
MozReview Request: bz://1156987/Yoric

For avoiding duplication and consistency I think we should clean up the core code from http://mxr.mozilla.org/mozilla-central/source/toolkit/devtools/event-emitter.js and put it in toolkit/modules/EventEmitter.jsm. It has a nice API including a promise based once form.

Comment 7

[David Teller [:Yoric] - still alive but not very active]

Attachment: MozReview Request: Bug 1156987 - Simple event mechanism