1156989 - [FM Radio][No Antenna] In many locales with SHB enabled, the text asking the user to plug in a headset is cut off by the SHB

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::FMRadio, defect, P2)

Description

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

Attachment: Overlap Screenshot

Description:
The Software home button overlaps the text in the radio app thats asks the user to plug in headphones in order for the radio app to function


Repro Steps:
1) Update a Flame to 20150421010201
2) Enable the Software Home Button
3) Switch the language to Arabic
4) Open radio app without headphones plugged in


Actual:
Text is overlapped by the SHB


Expected:
SHB does not overlap any text

Environmental Variables:
Device: Flame 3.0 (319mb)(Kitkat)(Full Flash)
Build ID: 20150421010201
Gaia: a8e4f95dce9db727dda5d408b038f97fb4296557
Gecko: 7b823253d9f2
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 40.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0


Repro frequency: 10/10
See attached: Logcat, Screenshot

Comment 1

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

This issue DOES occur on Flame 2.2

Text is overlapped by the SHB

Environmental Variables:
Device: Flame 2.2 (319mb)(Kitkat)(Full Flash)
Build ID: 20150421002501
Gaia: 828dd03a0e3b140d74b2e49355197df4d91d9227
Gecko: 36f72a3efb9b
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 37.0 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

===========================================================================

RTL is not supported on 2.1 or earlier builds so no branch checks were done.

Comment 2

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

Attachment: FM Radio RTL SHB Logcat

Comment 3

[Peter Bylenga [:PBylenga]]

I think this can be handled by l10n, we have reduced space due to SHB being enabled creating the cut off.  In English the paragraph is shorter not encountering the issue.

NI Delphine to take a look.

Comment 4

[Delphine Lebédel [:delphine - Use needinfo]]

Extra testing needed because I suspect this happens in many other locales, especially those who have longer words.

Comment 5

[Delphine Lebédel [:delphine - Use needinfo]]

(did not intend to put P3 here, sorry for the noise)

Comment 6

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

This bug did NOT reproduce in Italian, French, Welsh, Hebrew, Indonesian, Kiswahili, or Russian.

This bug DID reproduce in German.

If there are any specific languages that need to be checked please NI me and let me know

Comment 7

[Delphine Lebédel [:delphine - Use needinfo]]

Thanks Derek. This probably means this happens in other languages.
I've done a quick search using Transvision, and playing with locales from the dropdown: https://transvision.mozfr.org/?recherche=FM+Radio+requires+a+plugged+in&repo=gaia&sourcelocale=en-US&locale=as&search_type=strings

Seems like locales like Assamese, Czech, Spanish (just examples) would be affected as well. If this SHB feature is likely going to be used a lot on 2.2 and onwards, I would suggest this get a dev fix vs an l10n one. I don't know much about this feature and how much it will be used, so can't tell if we should block on this or not.

Also, taking out RTL keywords as this is not only in RTL

Comment 8

[No-Jun Park [:njpark]]

Hi Delphine, do you think this is worth blocking for 3.0?  covering SHB seems serious enough that it would qualify as a blocker.

Comment 9

[Delphine Lebédel [:delphine - Use needinfo]]

Hi No-Jun. Yes I agree this qualifies as a blocker for 3.0. I'll block on this now, given comment 8. thanks!

Comment 10

[Hubert Figuiere [:hub]]

For some reason the display is bigger than actually visible.

Also while it happens on the Flame that doesn't need SHB, it is fine on Aries, but that's possibly related to the DPI and font.

Comment 11

[GitHub Autolander Bot]

Attachment: [gaia] hfiguiere:bug1156989-fm-shb-text > mozilla-b2g:master

Comment 12

[Hubert Figuiere [:hub]]

Comment on attachment 8656768 [details] [review]
[gaia] hfiguiere:bug1156989-fm-shb-text > mozilla-b2g:master

If there is a better reviewer, let me know.

Comment 13

[Hubert Figuiere [:hub]]

Comment on attachment 8656768 [details] [review]
[gaia] hfiguiere:bug1156989-fm-shb-text > mozilla-b2g:master

Justin volunteered.

Comment 14

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8656768 [details] [review]
[gaia] hfiguiere:bug1156989-fm-shb-text > mozilla-b2g:master

Ship it!

Comment 15

[Hubert Figuiere [:hub]]

Merged
https://github.com/mozilla-b2g/gaia/commit/ea8866ae99d5e298dad43de4fc030e10f5ac16f2

Comment 16

[Autumn.Qiu(Leave from Mozilla)]

Attachment: Verified_FlameKK_v2.5.png

This bug has been verified as "pass" on the latest build of Flame KK v2.5 by the STR in comment 0.

Actual results: After changing to Arabic,SHB does not overlap any text in FM radio.
See attachment: Verified_FlameKK_v2.5.png
Reproduce rate: 0/10

Device: Flame KK 2.5 (Pass)
Build ID               20150905150219
Gaia Revision          03be7d8918bed58c92a40bba211bbbc97a0e516a
Gaia Date              2015-09-04 11:56:30
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/139446daedab3d00b9f0faba25e1e82191c8c8d1
Gecko Version          43.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150905.183746
Firmware Date          Sat Sep  5 18:38:03 EDT 2015

Comment 17

[GitHub Autolander Bot]

Attachment: [gaia] mozilla-b2g:revert-31682-bug1156989-fm-shb-text > mozilla-b2g:master

Comment 18

[Hubert Figuiere [:hub]]

As per bug 1202208 reverted 

https://github.com/mozilla-b2g/gaia/commit/6bba9182593d3e637cd950df160e96daf43664d9

Comment 19

[GitHub Autolander Bot]

Attachment: [gaia] hfiguiere:bug1156989-layout > mozilla-b2g:master

Comment 20

[Hubert Figuiere [:hub]]

Comment on attachment 8658202 [details] [review]
[gaia] hfiguiere:bug1156989-layout > mozilla-b2g:master

I needed to put the display: flex in a different CSS rule. Because it broke things.

Comment 21

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8658202 [details] [review]
[gaia] hfiguiere:bug1156989-layout > mozilla-b2g:master

Same as the last patch, except this should now address Bug 1202208.

Comment 22

[Hubert Figuiere [:hub]]

Merged
https://github.com/mozilla-b2g/gaia/commit/a2ebad76472d3f082a62e6c0d8889e4445ae0e73