If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

PeerConnectionImpl::AddIceCandidate defaults Index to zero

NEW
Unassigned

Status

()

Core
WebRTC: Signaling
P3
normal
Rank:
29
3 years ago
11 days ago

People

(Reporter: drno, Unassigned)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(firefox40 affected)

Details

(Reporter)

Description

3 years ago
As pointed out in bug 1087551 our current implementation of PeerConnectionImpl::AddIceCandidate 
https://dxr.mozilla.org/mozilla-central/source/media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp?from=PeerConnectionImpl.cpp:1790

defaults a missing Index value to zero as the nullable webidl apparently gets translated into a zero.

To be able to create and pass in RTCIceCandidates with just a Mid set, but no Index set, the index needs to become optional.
As noted, the identified signature is incapable of expressing the absence of the aMid or aLevel parameters.

This logic should be moved to JsepSessionImpl, where the m-line can be correctly identified.  PeerConnectionMedia::AddIceCandidate doesn't use the mid, so once JsepSessionImpl works out where the candidate belongs, it should return that value so that it can be passed to PCM.
(Reporter)

Updated

3 years ago
See Also: → bug 1087551

Updated

2 years ago
backlog: --- → webRTC+
Rank: 45
Priority: -- → P4
(Reporter)

Updated

10 months ago
Rank: 45 → 29
Priority: P4 → P2
Mass change P2->P3 to align with new Mozilla triage process.
Priority: P2 → P3
You need to log in before you can comment on or make changes to this bug.