Open
Bug 1157034
Opened 9 years ago
Updated 2 years ago
PeerConnectionImpl::AddIceCandidate defaults Index to zero
Categories
(Core :: WebRTC: Signaling, defect, P3)
Core
WebRTC: Signaling
Tracking
()
NEW
Tracking | Status | |
---|---|---|
firefox40 | --- | affected |
backlog | webrtc/webaudio+ |
People
(Reporter: drno, Unassigned)
References
Details
As pointed out in bug 1087551 our current implementation of PeerConnectionImpl::AddIceCandidate https://dxr.mozilla.org/mozilla-central/source/media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp?from=PeerConnectionImpl.cpp:1790 defaults a missing Index value to zero as the nullable webidl apparently gets translated into a zero. To be able to create and pass in RTCIceCandidates with just a Mid set, but no Index set, the index needs to become optional.
Comment 1•9 years ago
|
||
As noted, the identified signature is incapable of expressing the absence of the aMid or aLevel parameters. This logic should be moved to JsepSessionImpl, where the m-line can be correctly identified. PeerConnectionMedia::AddIceCandidate doesn't use the mid, so once JsepSessionImpl works out where the candidate belongs, it should return that value so that it can be passed to PCM.
Updated•9 years ago
|
backlog: --- → webRTC+
Rank: 45
Priority: -- → P4
Reporter | ||
Updated•8 years ago
|
Rank: 45 → 29
Priority: P4 → P2
Comment 2•7 years ago
|
||
Mass change P2->P3 to align with new Mozilla triage process.
Priority: P2 → P3
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•