Closed Bug 1157046 Opened 7 years ago Closed 7 years ago

Remove ARRAY_LENGTH in favor of MOZ_ARRAY_LENGTH

Categories

(Core :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

Details

Attachments

(1 file)

No description provided.
Flags: needinfo?(ehsan)
Attachment #8595703 - Flags: review?(jwalden+bmo)
Flags: needinfo?(ehsan)
Comment on attachment 8595703 [details] [diff] [review]
Remove ARRAY_LENGTH in favor of mozilla::ArrayLength

Review of attachment 8595703 [details] [diff] [review]:
-----------------------------------------------------------------

So this is fine enough, but your patch depends on mozilla::ArrayLength being constexpr on all compilers, everywhere.  I didn't think we could depend on that yet.  I'd expect this to fail tryservering on Windows with MSVC.

If it doesn't fail try, great.  If it does, you want MOZ_ARRAY_LENGTH for all of this instead.  I don't need to see such a refactoring of this patch, if needed.
Attachment #8595703 - Flags: review?(jwalden+bmo) → review+
Sigh... You were right about Windows.
https://hg.mozilla.org/mozilla-central/rev/799e17c366bf
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.