Closed
Bug 1157062
Opened 9 years ago
Closed 9 years ago
[DeviceStorage] Don't create static (aka global) string objects.
Categories
(Core :: DOM: Device Interfaces, defect)
Core
DOM: Device Interfaces
Tracking
()
RESOLVED
INVALID
People
(Reporter: dhylands, Assigned: dhylands)
References
Details
Attachments
(1 file)
|
2.04 KB,
patch
|
Details | Diff | Splinter Review |
In particular, bug 1072535 introduced some static nsLiteralString objects, which essentially create global static destructors and constructors. This bug is to change that to something which doesn't need a constructor.
|
Assignee | |
Comment 1•9 years ago
|
||
Try run with this patch: https://treeherder.mozilla.org/#/jobs?repo=try&revision=149f465ac362
Attachment #8596071 -
Flags: review?(neil)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8596071 [details] [diff] [review] Replace nsLiteralStrings with POD Actually froydnj has since told me that it's not so bad for these static const function-local variables, as they use one-time initialisation instead, which is not quite as bad as a true static constructor.
Attachment #8596071 -
Flags: review?(neil)
|
|
Assignee | |
Comment 3•9 years ago
|
||
OK - then closing this.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•