GFX: MIPS: Optimize 2D operations by Loongson3 MMI

RESOLVED FIXED in Firefox 41

Status

()

Core
Graphics
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: hev, Assigned: hev)

Tracking

Trunk
mozilla41
Other
Linux
Points:
---

Firefox Tracking Flags

(firefox40 affected, firefox41 fixed)

Details

Attachments

(8 attachments)

(Assignee)

Description

3 years ago
Hi,

The GS464 core of Loongson3 implemented a SIMD ASE like as intel MMX, we call it Loongson3 MMI. This is a 64-bit SIMD instruction set, it isn't support floating point.

In public, it used by another open source project pixman for Loongson3. currently, we want to public some 2d operations implemented in LS3 MMI.
(Assignee)

Updated

3 years ago
Assignee: nobody → r
(Assignee)

Comment 1

3 years ago
Created attachment 8595687 [details] [diff] [review]
0001-GFX-2D-Add-Loongson3-MMI-helpers.patch

This is a helpers for translate SSE instruction interface to MMI and used by next patches.
Attachment #8595687 - Flags: review?(tnikkel)
Comment on attachment 8595687 [details] [diff] [review]
0001-GFX-2D-Add-Loongson3-MMI-helpers.patch

Did you mean to request review from me? I don't think I'm the right reviewer for this. Jeff or Bas can likely help here.
Attachment #8595687 - Flags: review?(tnikkel)
Attachment #8595687 - Flags: review?(jmuizelaar)
Attachment #8595687 - Flags: review?(bas)
(Assignee)

Comment 3

3 years ago
Created attachment 8595706 [details] [diff] [review]
0002-GFX-2D-Implement-skia-Convolve-in-LS3-MMI.patch

This patch added a new source file convolverLS3.cpp, will build in every mips platforms, just enabled for Loongson3 (-march=loongson3a).
Attachment #8595706 - Flags: review?(jmuizelaar)
Attachment #8595706 - Flags: review?(bas)
(Assignee)

Comment 4

3 years ago
Created attachment 8595707 [details] [diff] [review]
0003-GFX-2D-Implement-AlphaBoxBlur-in-LS3-MMI.patch
Attachment #8595707 - Flags: review?(jmuizelaar)
Attachment #8595707 - Flags: review?(bas)
Comment on attachment 8595706 [details] [diff] [review]
0002-GFX-2D-Implement-skia-Convolve-in-LS3-MMI.patch

Review of attachment 8595706 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/2d/moz.build
@@ +109,1 @@
>  

I don't think this is correct. There are mips chips without LS3.
Attachment #8595706 - Flags: review?(jmuizelaar) → review-
(the actual code seems protected by #if defined(_MIPS_ARCH_LOONGSON3A) so it should be safe to build on all mips)
(Assignee)

Comment 7

3 years ago
(In reply to Jeff Muizelaar [:jrmuizel] from comment #5)
> Comment on attachment 8595706 [details] [diff] [review]
> 0002-GFX-2D-Implement-skia-Convolve-in-LS3-MMI.patch
> 
> Review of attachment 8595706 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: gfx/2d/moz.build
> @@ +109,1 @@
> >  
> 
> I don't think this is correct. There are mips chips without LS3.

Thanks.

(In reply to Vladimir Vukicevic [:vlad] [:vladv] from comment #6)
> (the actual code seems protected by #if defined(_MIPS_ARCH_LOONGSON3A) so it
> should be safe to build on all mips)

You are right, Thanks for you help.
(Assignee)

Comment 8

3 years ago
Comment on attachment 8595706 [details] [diff] [review]
0002-GFX-2D-Implement-skia-Convolve-in-LS3-MMI.patch

Review of attachment 8595706 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/2d/moz.build
@@ +109,1 @@
>  

Thanks, the real codes protected by '#if defined(_MIPS_ARCH_LOONGSON3A)'.
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
Can we please clean up the reviews here? I see pending ones and one patch that has an outright review- on it.
Keywords: checkin-needed
(Assignee)

Updated

3 years ago
Attachment #8595706 - Flags: review?(jmuizelaar)
Attachment #8595706 - Flags: review?(bas)
Attachment #8595706 - Flags: review-
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
(Assignee)

Comment 11

3 years ago
Created attachment 8610294 [details] [diff] [review]
0004-GFX-Skia-Implement-SkUtils-in-LS3-MMI.patch
Attachment #8610294 - Flags: review?(jmuizelaar)
(Assignee)

Comment 12

3 years ago
Created attachment 8610296 [details] [diff] [review]
0005-GFX-Skia-Add-Loongson-MMI-helpers.patch
Attachment #8610296 - Flags: review?(jmuizelaar)
(Assignee)

Comment 13

3 years ago
Created attachment 8610297 [details] [diff] [review]
0006-GFX-Skia-Implement-SkBitmap-in-LS3-MMI.patch
Attachment #8610297 - Flags: review?(jmuizelaar)
(Assignee)

Comment 14

3 years ago
Created attachment 8610298 [details] [diff] [review]
0007-GFX-Skia-Implement-SkBlitRow-in-LS3-MMI.patch
Attachment #8610298 - Flags: review?(jmuizelaar)
(Assignee)

Comment 15

3 years ago
Created attachment 8610299 [details] [diff] [review]
0008-GFX-Skia-Implement-SkBlitMask-in-LS3-MMI.patch
Attachment #8610299 - Flags: review?(jmuizelaar)
https://hg.mozilla.org/mozilla-central/rev/3082e57356c7
https://hg.mozilla.org/mozilla-central/rev/3518021ad9fa
https://hg.mozilla.org/mozilla-central/rev/7e403c08e539
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
(Assignee)

Updated

3 years ago
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 8610294 [details] [diff] [review]
0004-GFX-Skia-Implement-SkUtils-in-LS3-MMI.patch

Review of attachment 8610294 [details] [diff] [review]:
-----------------------------------------------------------------

Please submit all of the skia optimizations to upstream skia. They will flow into our tree from there.
Attachment #8610294 - Flags: review?(jmuizelaar) → review-
(Assignee)

Updated

3 years ago
Status: REOPENED → RESOLVED
Last Resolved: 3 years ago3 years ago
Resolution: --- → FIXED
Attachment #8595707 - Flags: review?(bas)
Attachment #8595687 - Flags: review?(bas)
You need to log in before you can comment on or make changes to this bug.