Closed Bug 1157092 Opened 8 years ago Closed 8 years ago

Permaorange apps/system/test/marionette/text_selection_test.js | Text selection > without lockscreen check functionality copy and paste across all trees independent of merges

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
blocker

Tracking

(b2g-v2.2 fixed, b2g-master fixed)

Status:
RESOLVED FIXED
Milestone:
2.2 S11 (1may)
Tracking Flags:
Tracking Status
b2g-v2.2 --- fixed
b2g-master --- fixed

People

(Reporter: philor, Assigned: gduan)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

[gaia] cctuan:1157092 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
mtseng
: review+
Details | Review 
Started on mozilla-central on a merge of a green cset from mozilla-inbound on top of a green merge from fx-team. Started on b2g-inbound on the merge from mozilla-central. At that point, you were looking like a poor innocent victim of bustage from some evil upstream Gecko hacker.

But, started on mozilla-inbound two csets below the merge from mozilla-central, which is on something which hadn't been merged to mozilla-central, and retriggers on csets below where it started are coming back failing. At this point, you look like your tests have external dependencies not pinned in tree, which is a major party foul and a violation of the visibility requirements, or an invisible change in the TaskCluster infra where they run broke you. Either way, Gij-24 is hidden on all trunk trees.
Blocks: 1157093
We can't have test suites hidden because of this, so disabling the test for now: https://github.com/mozilla-b2g/gaia/commit/bc4da42059215dec9261e3395dabf1ef1a1538dc

It also seems highly unlikely that this is relying on external things, though maybe a date or a config change could've happened triggering this.

George - could you look into this when you get a chance?
Flags: needinfo?(gduan)
I can't see why because the test pass on my local side, so I enable it and push to gaia-try again.
Assignee: nobody → gduan
Flags: needinfo?(gduan)
Test still fail.

I guess probably the content of input is not pasted fully yet, so I modified some test code. Waiting for the result.
Comment on attachment 8597821 [details] [review]
[gaia] cctuan:1157092 > mozilla-b2g:master

Comment 19 is wrong. I still have no idea why it only copy 1st half of the input content. 

In order to put this test back to tbpl, I shorten the text and the test pass now.

Hi Morris,
could you help to review this patch? We still need to deeply look into this bug...
Attachment #8597821 - Flags: review?(mtseng)
Comment on attachment 8597821 [details] [review]
[gaia] cctuan:1157092 > mozilla-b2g:master

LGTM!
Attachment #8597821 - Flags: review?(mtseng) → review+
Whiteboard: checkin-needed
Master: https://github.com/mozilla-b2g/gaia/commit/d21634aa49f980f34e8d1b0928af4eb6b1799fd8
v2.2:   https://github.com/mozilla-b2g/gaia/commit/84e3332b5064718afba49c1c5c8977614fa52c2f
Status: NEW → RESOLVED
Closed: 8 years ago
status-b2g-v2.2: --- → fixed
status-b2g-master: --- → fixed
Resolution: --- → FIXED
Whiteboard: checkin-needed
Target Milestone: --- → 2.2 S11 (1may)
You need to log in before you can comment on or make changes to this bug.