1157108 - onpush EventHandler support

Status: RESOLVED FIXED

(Core :: DOM: Push Subscriptions, defect)

Description

[Doug Turner (:dougt)]

From a SW, 'onpush' doesn't work.

this.onpush = function(event) {
  debug("onpush");
}

onpushsubscriptionchange also doesn't work.

Comment 1

[Doug Turner (:dougt)]

Attachment: onpush_impl

Comment 2

[(no longer active)]

Comment on attachment 8596051 [details] [diff] [review]
onpush_impl

Review of attachment 8596051 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/push/test/worker.js
@@ +1,5 @@
>  // Any copyright is dedicated to the Public Domain.
>  // http://creativecommons.org/licenses/publicdomain/
>  
> +
> +//addEventListener("push", handlePush);

Did you forget to remove this comment?

::: dom/webidl/ServiceWorkerGlobalScope.webidl
@@ +30,5 @@
>    attribute EventHandler onmessage;
> +
> +  // These are from w3c.github.io/push-api/
> +  attribute EventHandler onpush;
> +  attribute EventHandler onpushsubscriptionchange;

Please copy and paste this from the spec, as a partial interface, preserving the comment above.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cbabce5695c4

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cbabce5695c4