1157128 - Http Auth broken

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect)

Description

[Jonathan Hao (inactive) [:jhao]]

Using Flame, open the browser and navigate to http://tiv-dmz.homeip.net

This website requires username and password, but I can't enter them because there's no input box.

Comment 1

[Gregor Wagner [:gwagner]]

Can we get a video?

Comment 2

[Gregor Wagner [:gwagner]]

And branch check.

Comment 3

[Pi Wei Cheng [:piwei] (inactive)]

This issue reproduces on Flame 3.0. If you access the website via a computer you can see the website's authentication method is a dialog popping up upon accessing, and on Flame 3.0 there is no dialog popping up and there are no input fields next to username and password. See video:

https://www.youtube.com/watch?v=_uv1oXSdv_g

Device: Flame 3.0
BuildID: 20150422010202
Gaia: 15134b080b5f406e5aa36f5136c17dafb4e31f64
Gecko: 946ac85af8f4
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 40.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

----

This issue does NOT reproduce on Flame 2.2. There are two fields available on the website accepting input.

Device: Flame 2.2
BuildID: 20150422002505
Gaia: 41a85c5f9db291d4f7c0e94c8416b5115b4ee407
Gecko: a87a05e7d0ef
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 4

[Pi Wei Cheng [:piwei] (inactive)]

Note that on v2.2 although input fields are there, they're not labeled (username field doesn't say username, and password field doesn't say password. Although the order of these input boxes are intuitive, it does still seem odd without labeling)

Comment 5

[Shally Li（leave from Mozilla）]

I'm try to find the broken window.

Comment 6

[Shally Li（leave from Mozilla）]

According to the STR of comment 0， I find that the B2g-inbound regression results are abnormal.

--------------------------------------------------------------------------------------------
B2g-inbound Regression Window:

This issue DOES repro (Fail):only shows the words "username" and "password",no input box. (bug_NoInputbox.png)
This issue DOES NOT repro (Pass):it shows two input boxes, but no prompt text "username" and "password" in the website. (show_inputbox.png)

20150328214220 	-> Pass  	 
20150329042818  -> Fail 	 
20150329235918 	-> Fail	 
20150330001019 	-> Fail 	 
20150330140843 	-> Fail	 
20150330144345 	-> Fail	 
20150330162405 	-> Fail 
20150330171401 	-> Fail	 
20150330174902 	-> Fail	 
20150330180400 	-> Pass	 
20150330192902 	-> Pass		 	 
20150330230404  -> Pass	 	 
20150331010905  -> Fail	
20150401160204  -> Fail	

--------------------------------------------------------------------

Last Working Environmental Variables:
Device: Flame v3.0
Build ID               20150330230404
Gaia Revision          36b6f9f824782457ae0674382604cb69d915dee4
Gaia Date              2015-03-31 05:33:10
Gecko Revision         https://hg.mozilla.org/integration/b2g-inbound/rev/29b1685738e0
Gecko Version          40.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150329.042104
Firmware Date          Sun Mar 29 04:21:16 EDT 2015
Bootloader             L1TC000118D0

First Broken Environmental Variables:
Device: Flame v3.0
Build ID               20150331010905
Gaia Revision          d08600b883589cfb556a7a3f39310b6b4e8106a0
Gaia Date              2015-03-31 07:21:41
Gecko Revision         https://hg.mozilla.org/integration/b2g-inbound/rev/e982d356e37a
Gecko Version          40.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150330.191926
Firmware Date          Mon Mar 30 19:19:35 EDT 2015
Bootloader             L1TC000118D0

First Broken Gaia & Last Working Gecko - issue DOES repro
Gaia-Rev        d08600b883589cfb556a7a3f39310b6b4e8106a0
Gecko-Rev       https://hg.mozilla.org/integration/b2g-inbound/rev/29b1685738e0

First Broken Gecko & Last Working Gaia - issue DOES NOT repro
Gaia-Rev        36b6f9f824782457ae0674382604cb69d915dee4
Gecko-Rev       https://hg.mozilla.org/integration/b2g-inbound/rev/e982d356e37a

Gaia log: logcat_0225.txt.
Please see attachments: bug_NoInputbox.png and show_inputbox.png.

Comment 7

[Shally Li（leave from Mozilla）]

Attachment: logcat_0225.txt

Comment 8

[Shally Li（leave from Mozilla）]

Attachment: bug_NoInputbox.png

Comment 9

[Shally Li（leave from Mozilla）]

Attachment: show_inputbox.png

Comment 11

[Dale Harvey (:daleharvey)]

Ill take a look here

Comment 12

[Dale Harvey (:daleharvey)]

http auth is straight up broken, http://httpbin.org/basic-auth/user/passwd also fails, nothing particularly revealing in the log

Comment 13

[Robert Kaiser]

As a side note, could we have some test once this bug is fixed so we immediately get attention to this if we break HTTP Auth again? This is the second time in the last months that HTTP Auth is completely broken in some fashion. :(

Comment 14

[Dale Harvey (:daleharvey)]

Yup taking a look since there is an integration test for this functionality @ http://mxr.mozilla.org/gaia/source/apps/system/test/marionette/app_authentication_dialog_test.js?force=1, but checking why its not caught anything

Comment 15

[GitHub Autolander Bot]

Attachment: [gaia] daleharvey:1157128 > mozilla-b2g:master

Comment 16

[Dale Harvey (:daleharvey)]

https://github.com/mozilla-b2g/gaia/pull/29747 fixes this, was caused by a recent l10n changes that strip the input due to the l10n-id, the test doesnt actually perform a login which is why this isnt caught, will get a test written before getting this in to review

Comment 17

[Doug Sherk (:drs) (inactive)]

Bhavana, this should block Spark. Though it looks like it's going to be resolved soon, so it may land before we can set tracking.

Comment 18

[Zibi Braniecki [:zbraniecki][:gandalf]]

Dale, in bug 1157631 I'm fixing the same bug but I am leaving the l10n-ids. Do you prefer your solution?

If so, and if the entities are not used anywhere else, you should also remove the l10n strings from resource file.

Comment 20

[Dale Harvey (:daleharvey)]

Comment on attachment 8598141 [details] [review]
[gaia] daleharvey:1157128 > mozilla-b2g:master

I added a thing in server_child that lets people login with 'username' and 'password', so now we test the actual login flow

Comment 21

[Kevin Grandon :kgrandon]

Comment on attachment 8598141 [details] [review]
[gaia] daleharvey:1157128 > mozilla-b2g:master

LGTM. Thanks for the test.

Comment 22

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/b52d22d93a36bb3ab63e028f701a82c284d2e74a

Comment 23

[Hermes Cheng (inactive after July 27, 2015)]

Dale, could you please also uplift to v2.2 since the patch is also for bug 1157631 which is a 2.2 blocker?

Comment 24

[Dale Harvey (:daleharvey)]

Comment on attachment 8598141 [details] [review]
[gaia] daleharvey:1157128 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): https://bugzilla.mozilla.org/show_bug.cgi?id=1073893
[User impact] if declined: Cant log in to http auth websites
[Testing completed]: Manually verified, automated tests added
[Risk to taking this patch] (and alternatives if risky): low risk
[String changes made]: none

Comment 25

[Shally Li（leave from Mozilla）]

According to the STR of Comment 0,this bug has been successfully verified on latest Nightly Flame v3.0.

Actual results:It shows "USERNAME","PASSWORD" and two inputing boxes.
See attachment: verified_v3.0.png
Reproduce rate: 0/5


Device: Flame 3.0 build(Pass)
Build ID               20150503160200
Gaia Revision          e18cce173840d6ff07fb6f1f0e0ffb58b99aab3e
Gaia Date              2015-05-02 04:27:01
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/dc5f85980a82
Gecko Version          40.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150503.193941
Firmware Date          Sun May  3 19:39:52 EDT 2015
Bootloader             L1TC000118D0

-----------------------------------------------------------------
Note:
On Flame v2.2,it only shows inputing boxes and doesn't show the words "USERNAME" "PASSWORD".

Comment 26

[Shally Li（leave from Mozilla）]

Attachment: verified_v3.0.png

Comment 27

[GitHub Autolander Bot]

Attachment: [gaia] daleharvey:1157128-v2 > mozilla-b2g:v2.2

Comment 28

[Dale Harvey (:daleharvey)]

Running a test against 2.2 and will land will green

Comment 29

[Hermes Cheng (inactive after July 27, 2015)]

NI myself for reminding, in case I miss the update. Need it to verify bug 1157432.

Comment 30

[Alberto Pastor [:albertopq]]

Dale, could you please take a look to the 2.2 uplift? Thanks!

Comment 31

[Dale Harvey (:daleharvey)]

Getting 218 failures on 2.2, certainly not caused by this patch, anyone know what the state of integration tests for 2.2. I cant really see landing this with so many failures.

Comment 32

[Kevin Grandon :kgrandon]

Yeah, sounds like 2.2 try needs some help. I'm sure we're missing some chnages that we've done on master, but I'm not sure what they are. I think James or Aus might have an idea, so redirecting the needinfo.

Comment 34

[James Lal [:lightsofapollo]]

So it looks like on v2.2 we where still pulling mozilla-central... (which no longer has builds for b2g-desktop) fixed here https://bugzilla.mozilla.org/show_bug.cgi?id=1162630

Comment 35

[GitHub Autolander Bot]

Attachment: [gaia] albertopq:1157128-uplift-v2.2 > mozilla-b2g:v2.2

Comment 36

[Alberto Pastor [:albertopq]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/cc0014b193d5669988c6567ed0ed7f9d9112580d

Comment 37

[Shally Li（leave from Mozilla）]

This bug has been verified as pass on latest Nightly build of Flame v2.2 by the STR in Comment 0.

Actual results:It shows "USERNAME","PASSWORD" and two inputing boxes in "http://tiv-dmz.homeip.net".
See above attachment: verified_v3.0.png
Reproduce rate: 0/5

Device: Flame v2.2 build(Pass)
Build ID               20150512162502
Gaia Revision          e048df68f6f4853b5826a8816e143d95258149de
Gaia Date              2015-05-12 19:10:26
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/9edadb35caca
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150512.202452
Firmware Date          Tue May 12 20:25:03 EDT 2015
Bootloader             L1TC000118D0