1157149 - The unclassified failure count in the page title should show how many are present with filters applied

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P3)

Description

[James Graham [:jgraham]]

When pushing to a twig branch I often only care about a subset of jobs (yes, this is hideously inefficient; that's a separate problem). In this case I use a filter to view only the jobs I'm interested in. Therefore the count of failed jobs in the title bar isn't much use to me at all because it applies to all jobs, not just those matching the filter.

Comment 1

[Ed Morley [:emorley]]

I suspect this would negatively impact sheriffs, since a common case for them might be:
* filter to a certain job type to investigate something
* forget to reset the job & switch to another tab
-> expect the pinned tab to turn blue when new unclassified failures appear

Sheriffs, could you confirm either way?

If it would impact them, perhaps this is something that we could have a toggle on the future prefs page for?

Comment 2

[Ryan VanderMeulen [:RyanVM]]

From a quick bugmail scan, I think bug 1031867 has the most pertinent discussion for this.

And yes, I'd prefer that the behavior here be non-default if it's be to made possible.

Comment 3

[James Graham [:jgraham]]

Is there something that would work for both Sheriffs and everyone else (assuming that I am close to a prototypical non-sheriff in this case, which may not be true). For example if the title became "[6/83] cedar" when a filter was applied.

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I typically open filtered views into new tabs if I'm tracking something, so forgetting I'm in a filtered view doesn't happen often. I'm more inclined to agree with comment 0 ("why do n/p not do anything, tab title says there's x unclassified failures showing?")

Comment 5

[Ed Morley [:emorley]]

Ryan/Wes, would having both numbers in the title be ok for you?

eg: "[6/83] cedar"

This would mean the tab title would change colour even if the change in unclassified count was relating to things not visible with the current filter (though this might be useful: if a filter is active, it reminds people that things have happened outside of it, and that they might need to deactivate the filter).

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I'd be okay with that.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Worth a shot

Comment 10

[Cameron Dawson [:camd]]

I have a branch I'm working on for this (filtered-unclassified-count).  I'd talked to Wes a bit about it in IRC.  We were going to have the "main" unclassified count (yellow button) reflect unclassified in the selected Tiers of jobs.  (i.e. - if you're only showing tiers 1 and 2, then Tier-3 won't count)  However, if you only select Tier-3, then the count will reflect only Tier-3, etc.

For filtering, I was going to display a second number right next to the button for that count.  Not totally decided yet.  It's still a WIP branch, however.

Comment 11

[Phil Ringnalda (:philor)]

(In reply to Ed Morley [:emorley] from comment #5)
> Ryan/Wes, would having both numbers in the title be ok for you?
> 
> eg: "[6/83] cedar"

Wouldn't work for me: we're going to have hundreds of unclassified tier-3 jobs with B2G, so title changes resulting in pinned-tab color changes will make pinning to watch for results completely useless. Showing the total number somewhere in the page, but only the filtered number in the title, seems more likely to work out.

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(In reply to Phil Ringnalda (:philor) from comment #11)
> (In reply to Ed Morley [:emorley] from comment #5)
> > Ryan/Wes, would having both numbers in the title be ok for you?
> > 
> > eg: "[6/83] cedar"
> 
> Wouldn't work for me: we're going to have hundreds of unclassified tier-3
> jobs with B2G, so title changes resulting in pinned-tab color changes will
> make pinning to watch for results completely useless. Showing the total
> number somewhere in the page, but only the filtered number in the title,
> seems more likely to work out.

Ooh, I like that.

Comment 13

[Ed Morley [:emorley]]

My proposal for having both in the title, was when "filters" just meant eg the quicksearch box - and not tier 3 (which didn't exist).

I agree you wouldn't want tier 3 (if not selected) showing in the title.

Comment 14

[GitHub Autolander Bot]

Attachment: [treeherder] mozilla:unclassified-count-by-tier > mozilla:master

Comment 15

[Cameron Dawson [:camd]]

Comment on attachment 8712944 [details] [review]
[treeherder] mozilla:unclassified-count-by-tier > mozilla:master

This PR is really just a bug fix so that the counts respect the chosen tiers.  Showing a count that respects all other filters will be another PR.  But this one paves a nice path to getting that number too.

Comment 16

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/16b8b7489ca905b59a2b931ba11fe62657c9cf13
Bug 1157149,1240210 - The unclassified failure count should respect selected tiers of jobs

Keep track of the count of unclassified jobs currently loaded that match the
selected Tier settings.

When an event takes place that could change that value (new jobs loaded, classified
or unclassified) then update that count again.  This uses the unclassified map like
we did before, but re-evaluates it as needed.

This also fixes a bug where the interaction of the Tier dropdown and the Filters panel
didn't interact correctly.

This same technique can be leveraged (in the future) to get a count of unclassified
for the current filter set as well.

Comment 17

[Cameron Dawson [:camd]]

This may involve work in some of these files/locations:

https://github.com/mozilla/treeherder/blob/f7b3d2f67d218580d8d5be97d558c5e72e57360d/ui/js/services/jobfilters.js#L21-L21

https://github.com/mozilla/treeherder/blob/dc3d9474d96fc89de12851bb7985c2203e242a36/ui/js/models/resultsets_store.js#L3-L3

Comment 18

[GitHub Autolander Bot]

Attachment: [treeherder] kkrivera:Bug-1157149 > mozilla:master

Comment 19

[Cameron Dawson [:camd]]

Comment on attachment 8799093 [details] [review]
[treeherder] kkrivera:Bug-1157149 > mozilla:master

Only marking this r- so far due to a couple requested changes.  Once those are fixed up, this'll be ready to merge.

Please re-r? me on this when it's ready.

Thanks again!

Comment 20

[Kris Rivera]

Pending PR for this bug
https://github.com/mozilla/treeherder/pull/1908

Comment 21

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/88766c37ab95fe5144d9273fe888db115c7e2a2e
Bug 1157149 - added a secondary count indicating the number of filtered unclassified failures (#1908)