1157160 - [l10n][Settings]Serbian Cyrillic: The text is too long, so it will overlap with toggle at Call Barring loading view.

Status: VERIFIED FIXED

(Mozilla Localizations :: sr / Serbian, defect)

Description

[Sue]

Attachment: call_barring.png

[1.Description]:
[l10n][v2.2][Settings]Serbian Cyrillic: When goes to Call Barring view, the text is too long, so it will overlap with toggle at Call Barring loading view.
See attachment:call_barring.png

[2.Testing Steps]: 
Prerequisite: Set system language as Српски.
1. Go to settings > Call Settings > click on Sim 1 (have a sim card included) 
2. Select "Call Barring" and observe the view. 
3. Observe the loading view.

[3.Expected Result]: 
3. There is no truncation. Nothing overlaps. The UI should not appear broken in any way. 

[4.Actual Result]: 
3. The text is too long, so it will overlap with toggle.

[5.Reproduction build]: 
Device: Flame 2.2 user (affected)
Build ID               20150421002501
Gaia Revision          828dd03a0e3b140d74b2e49355197df4d91d9227
Gaia Date              2015-04-20 18:28:39
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/36f72a3efb9b
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150421.042925
Firmware Date          Tue Apr 21 04:29:36 EDT 2015
Bootloader             L1TC00011

Device: Flame 2.1 user (unaffected)
Build ID               20150421001205
Gaia Revision          bbe983b4e8bebfec26b3726b79568a22d667223c
Gaia Date              2015-04-09 13:52:48
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/b85d4f4a6d61
Gecko Version          34.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150421.040717
Firmware Date          Tue Apr 21 04:07:27 EDT 2015
Bootloader             L1TC000118D0

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
16056

[8. Note]:
Flame 2.1 does not support Call Barring. There is no Call Barring option in Call Settings.

Comment 1

[Delphine Lebédel [:delphine - Use needinfo]]

The string was shortened by localizer on 2.1. I'm not quite sure why it got longer on 2.2 again. 

Vanjas: is this because you put a longer string this time around? Or have your changes not been picked up correctly from 2.1 to 2.2 (which would be worrisome)? Please let me know! thanks :)

Comment 2

[Vanja Tumbas [:civas]]

(In reply to Delphine Lebédel [:delphine - use need info] from comment #1)
> The string was shortened by localizer on 2.1. I'm not quite sure why it got
> longer on 2.2 again. 

What exactly do you mean by this one? I'm confused.

As far as I can see the English and Serbian versions of string are the same on all repos since 1.3:
*(master) https://transvision.mozfr.org/?recherche=Requesting+network+info%E2%80%A6+&repo=gaia&sourcelocale=en-US&locale=sr-Cyrl&search_type=strings_entities
*(2.1) https://transvision.mozfr.org/?recherche=Requesting+network+info%E2%80%A6&repo=gaia_2_1&sourcelocale=en-US&locale=sr-Cyrl&search_type=strings_entities
*(1.3) https://transvision.mozfr.org/?recherche=Requesting+network+info%E2%80%A6&repo=gaia_1_3&sourcelocale=en-US&locale=sr-Cyrl&search_type=strings_entities

PS: "…" is part of string, not a truncation.


Can UX team fix this by moving toggle buttons up by few pixsels or should I find a way to shorten the string across all repos?

Comment 3

[Delphine Lebédel [:delphine - Use needinfo]]

Sorry Vanja, Transvision was down yesterday (and still flaky now) so I couldn't get back to you about this. I think I was confused and looking at another string in Serbian Cyrillic in this case :/
I just checked (thanks to http://transvision.flod.org/ :P) and it's exact: you had already shortened the string in 2.1, and used the same in 2.2. 
Since there is no 2.1 screenshot attached to this bug, I'll do some investigating today on 2.1 and see if we should get a dev fix for this. 
Keeping the Ni on me so I can get to this later

Comment 4

[Delphine Lebédel [:delphine - Use needinfo]]

Attachment: 2.1screenshot.png

I confirm that 2.1 was already affected, and was truncated.
Vanja: is there anyway to shorten this string maybe? Or is that the shortest there is?

Comment 5

[Delphine Lebédel [:delphine - Use needinfo]]

Attachment: 2.1screenshot.png

Attaching 2.1 correct screenshot now.
On second thoughts: localizer already tried to shorten this string and probably can't more (see use of ellipsis). Would be good to get a UX fix for this, if possible

Comment 6

[Vanja Tumbas [:civas]]

> I confirm that 2.1 was already affected, and was truncated.
> Vanja: is there anyway to shorten this string maybe? Or is that the shortest
> there is?

Actualy I can make it shorter. Since it was also truncated in 2.1 I can fix it to save UX team the trouble.

Your call :)

Comment 7

[Delphine Lebédel [:delphine - Use needinfo]]

Aha! Thanks Vanja for letting me know this :)
In fact, when shortening is possible, we prefer to try that first, before making a UX fix. As long as it's possible and it stays understandable, then let's go with shortening the string.
Thanks a lot for the heads up Vanja, this helps :)

Comment 8

[Vanja Tumbas [:civas]]

Landed:
* gaia-l10n:   https://hg.mozilla.org/gaia-l10n/sr-Cyrl/rev/68f5d7dade33
*       2.1:   http://hg.mozilla.org/releases/gaia-l10n/v2_1/sr-Cyrl/rev/9b3d74f1fae6

Comment 9

[Sue]

Attachment: call_barring_correct.png

This issue has been verified passed on latest build of Flame 2.2 with the same steps in comment 0.
See attachment:call_barring_correct.png
Rate：0/3

Device: Flame 2.2 user (pass)
Build ID               20150426002504
Gaia Revision          265ca0bc9408c21fc4b25a259fcee7fb642cd06b
Gaia Date              2015-04-24 19:13:28
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/1908685d798d
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150426.040327
Firmware Date          Sun Apr 26 04:03:38 EDT 2015
Bootloader             L1TC000118D0

Comment 10

[Sue]

Attachment: v2.1_no_call_barring.png

Hi Delphine,
We have checked the Call Settings on Flame 2.1, and there is no Call Barring under Call Settings. Shall we change the value of "status-b2g-v2.1:" as "---" and close this Bug? I have uploaded the screenshot of Flame 2.1, please check it, thanks!
See attachment:v2.1_no_call_barring.png

Device: Flame 2.1 user
Build ID               20150427001201
Gaia Revision          bbe983b4e8bebfec26b3726b79568a22d667223c
Gaia Date              2015-04-09 13:52:48
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/82a14be0462c
Gecko Version          34.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150427.034910
Firmware Date          Mon Apr 27 03:49:21 EDT 2015
Bootloader             L1TC000118D0

Comment 11

[Delphine Lebédel [:delphine - Use needinfo]]

Hi Sue. Let's use the "wont fix" since it didn't exist!
thanks

Comment 12

[Sue]

Hi Delphine,
Thanks. Per comment 9~11, change the status to verified,fixed.