"Article Summary" adds wrapper div that prevents summary extraction

RESOLVED FIXED

Status

developer.mozilla.org
General
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: fscholz, Unassigned)

Tracking

Details

(Whiteboard: [specification][type:bug])

(Reporter)

Description

3 years ago
What did you do?
================
1. Set a nice summary block like on https://developer.mozilla.org/en-US/docs/Web/JavaScript
2. Noticed the meta desc is containing the second paragraph instead of the nicely written summary from the box
3. Cried

What happened?
==============
<div class="summary"><p></p></div> gets inserted by our CKEditor config.

What should have happened?
==========================
<p class="summary"></p> should have been inserted as this allows Kuma to extract the summary from this <p> instead of the second.

Is there anything else we should know?
======================================
This effects our SEO.

PR upcoming.

Comment 2

3 years ago
Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/9a1ed5870772111be2eaaf819d0dedde1e2445fe
Fix bug 1157161: Add summary class to p instead of a creating a wrapping div

https://github.com/mozilla/kuma/commit/bff7e6acaa6c3e95762b5d03d4b578505f859043
Merge pull request #3199 from Elchi3/bug1157161

Fix bug 1157161: Add summary class to p instead of a creating a wrapping div

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.