1157170 - [Settings]"Add contact" is displayed with truncation.

Status: VERIFIED WORKSFORME

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Lancy(Leave from Mozilla)]

Attachment: Screenshot_add contact.png

[1.Description]:
[l10n][v2.2][Settings]Spanish:Enable "Fixed Dialing Numbers", and add contact in "Authorized numbers" view, the "Add contact" is displayed with truncation.
See attachment:Screenshot_add contact.png.

[2.Testing Steps]: 
1.Set your phone language to Spanish.
2.Insert one or two SIM card to device.
3.Launch Settings and enter "Call settings".
4.Select SIM1/SIM2 -> tap "Fixed Dialing Numbers" and enable "Fixed Dialing Numbers".
5.Tap "Authorized numbers" in "Fixed Dialing Numbers" view.
6.Tap "Add" button in "Authorized numbers" view to add one phone number to the list.
7.Tap the "Add" button again.

[3.Expected Result]: 
8.The "Add contact" should not be displayed with truncation.

[4.Actual Result]: 
8.The "Add contact" is displayed with truncation.

[5.Reproduction build]: 
Device: Flame 2.2 user build (Affected)
Build ID               20150421002501
Gaia Revision          828dd03a0e3b140d74b2e49355197df4d91d9227
Gaia Date              2015-04-20 18:28:39
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/36f72a3efb9b
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150421.042925
Firmware Date          Tue Apr 21 04:29:36 EDT 2015
Bootloader             L1TC000118D0

Device Flame 2.1 user build (Unaffected)
Build ID               20150421001205
Gaia Revision          bbe983b4e8bebfec26b3726b79568a22d667223c
Gaia Date              2015-04-09 13:52:48
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/b85d4f4a6d61
Gecko Version          34.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150421.040717
Firmware Date          Tue Apr 21 04:07:27 EDT 2015
Bootloader             L1TC000118D0

[6.Reproduction Frequency]: 
Always Recurrence,10/10

[7.TCID]: 
16053

Comment 1

[Inma Barrios]

I think this is a UX fix rather than a localization issue.

Comment 2

[Delphine Lebédel]

Agreed. This is clearly a regression from 2.1, since localizer used the same string in both 2.1 and 2.2
This affects most surely other shipping locales. Nominating

Comment 3

[Delphine Lebédel]

Sorry this is kind of an edge case... un-nominating for this reason
Asking for UX help on this! thanks

Comment 4

[Stephany Wilkes]

How was it determined that there should not be any truncation?

Comment 5

[Delphine Lebédel]

Because it did not truncate in 2.1 and now it does in 2.2. Although the string could be shortened maybe to "add", I believe the above is sufficient criteria to get a fix in for this.
Also, if this regressed on Spanish, this probably means it regressed for many other locales. In this case, it's too complicated to ask everyone to shorten their strings.

However since I've been witnessing a bit of weirdness in similar bugs filed, I would like to be on the safe side and ask that the tester provide a screenshot for 2.1. Lancy: can you please provide that? Also ,please communicate to your team that when one branch is affected and the other isn't, that we need both screenshots. thanks

Comment 6

[Lancy(Leave from Mozilla)]

Attachment: Screenshot_add contact_v2.1.png

Delphine,

The screenshot for v2.1 has been added, thanks for your reminder!

Comment 7

[Delphine Lebédel]

Ok screenshot in comment 6 clearly confirmed that this is indeed a regression from 2.1. 
Since this is a regression, nominating for triage decision (kind of an edge case, but still a regression)

Removing UX since this was fixed on 2.1 - should not be dealt by UX.

Comment 8

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: index.png

Lancy, are you sure you are using Español language ? Because based on what I found here, there is no such string like what you reported in Español and they all look well.

Tested on my flame with latest 2.2 build.

-- device info --

Build ID               20150426162504
Gaia Revision          265ca0bc9408c21fc4b25a259fcee7fb642cd06b
Gaia Date              2015-04-24 19:13:28
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/1908685d798d
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150326.193247
Firmware Date          Thu Mar 26 19:32:58 EDT 2015
Bootloader             L1TC100118D0

Comment 9

[Lancy(Leave from Mozilla)]

Attachment: Verify1_Flame2.2_pass.png

Hi EJ chen,

Yes, in the old flame 2.2 user build, the "Add contact" is shown as "Agregar contacto" in Spanish, when adding the number for the second time, the "Agregar contacto" is displayed with truncation.
In the latest Flame 2.2 user build, the "Add contact" is shown as "Añadir contacto" in Spanish and the truncation dose not exist.

See attachment: Verify1_Flame2.2_pass.png.
Reproducing rate:0/5

Flame 2.2 user build (Unaffected):
Build ID               20150427002504
Gaia Revision          265ca0bc9408c21fc4b25a259fcee7fb642cd06b
Gaia Date              2015-04-24 19:13:28
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/1908685d798d
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150427.040119
Firmware Date          Mon Apr 27 04:01:31 EDT 2015
Bootloader             L1TC000118D0

Comment 10

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

I think that's mainly because the gap between user build & engineer build, so let's just ignore the false alarm.

Comment 11

[Inma Barrios]

Hi,

Just for the record, I edited "Add contact" in 2.2 to use "Añadir" instead of "Agregar". Both are synonymous in Spanish, being the former slightly shorter than the latter.

That might explain the issue referred by Lancy in comment 9.

Thank you guys!