1157172 - [Contacts] The hint text of "Zip code" on value selector button are displayed with truncation.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Lancy(Leave from Mozilla)]

Attachment: 2015-04-22-17-22-35.png

[1.Description]:
[l10n][v2.1&v2.2][Contacts]Spanish:Enter new contact view, the hint text of "Zip code" and "Birthday" on value selector button are displayed with truncation.
See attachment:Screenshot_new contact.png.

[2.Testing Steps]: 
1.Set your phone language to Spanish.
2.Lanch Contacts and taop "+" button to enter new contact view.
3.Scroll the view.

[3.Expected Result]: 
3.The hint text of "Zip code" and "Birthday" on value selector button should not  be displayed with truncation.

[4.Actual Result]: 
3.The hint text of "Zip code" and "Birthday" on value selector button are displayed with truncation.

[5.Reproduction build]: 
Device: Flame 2.2 user build (Affected)
Build ID               20150421002501
Gaia Revision          828dd03a0e3b140d74b2e49355197df4d91d9227
Gaia Date              2015-04-20 18:28:39
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/36f72a3efb9b
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150421.042925
Firmware Date          Tue Apr 21 04:29:36 EDT 2015
Bootloader             L1TC000118D0

Device Flame 2.1 user build (Affected)
Build ID               20150421001205
Gaia Revision          bbe983b4e8bebfec26b3726b79568a22d667223c
Gaia Date              2015-04-09 13:52:48
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/b85d4f4a6d61
Gecko Version          34.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150421.040717
Firmware Date          Tue Apr 21 04:07:27 EDT 2015
Bootloader             L1TC000118D0

[6.Reproduction Frequency]: 
Always Recurrence,10/10

[7.TCID]: 
Free Test

Comment 1

[Inma Barrios]

I think this is a UX fix rather than a localization issue.

Comment 2

[Delphine Lebédel [:delphine - Use needinfo]]

Agreed.
Nominating this for triage decision as this affects shipping locale (Spanish) and probably others.
Ni on UX to help with this. thanks!

Lancy: please file 2 separate bugs when 2 strings are affected. I'll keep this one for Zip COde. Please file another one for the string Birthday (and apply same flags/keywords/components/etc as here). thanks

Comment 3

[Elie]

Set system language to Rassian,this issue still exist on Flame 2.2&2.1：
[5.Reproduction build]: 
Device: Flame 2.2 user build (Affected)
Build ID               20150422002505
Gaia Revision          41a85c5f9db291d4f7c0e94c8416b5115b4ee407
Gaia Date              2015-04-21 17:23:41
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/a87a05e7d0ef
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150422.040316
Firmware Date          Wed Apr 22 04:03:27 EDT 2015
Bootloader             L1TC000118D0

Device Flame 2.1 user build (Affected)
Build ID               20150421001205
Gaia Revision          bbe983b4e8bebfec26b3726b79568a22d667223c
Gaia Date              2015-04-09 13:52:48
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/b85d4f4a6d61
Gecko Version          34.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150421.040717
Firmware Date          Tue Apr 21 04:07:27 EDT 2015
Bootloader             L1TC000118D0

[6.Reproduction Frequency]: 
Always Recurrence,10/10

Comment 4

[Lancy(Leave from Mozilla)]

Hi Delphine,
According to your comment 2, bug 1157589 has been submitted.
Thanks!

Comment 5

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

triage:
non-regression.

Comment 6

[Stephany Wilkes]

Flagging Amy to see if she can help on this one.

Comment 7

[Amy Lee [:amylee] UX]

(In reply to Stephany Wilkes from comment #6)
> Flagging Amy to see if she can help on this one.

NI Fang who is the VSD for contacts.

Comment 8

[Shine(Leave from Mozilla)]

Attachment: Polish_Zip code.png

* This problem cannot be reproduced on latest Flame 2.2 user build in Serbian Cyrillic, Bengali India, Greek, Portuguese Brazil and Arabic languages.
* It can be reproduced on latest Flame 2.2 user build in Polish, Basque and Portuguese Portugal languages.
Please see attachments: Polish_Zip code.png, Basque_Zip code.png, Portuguese Portugal_Zip code.png

Device: Flame2.1 user
Build ID               20150511001203
Gaia Revision          3e7bd686ecd852f4dfa4605b45f558e6bd34f02a
Gaia Date              2015-05-07 15:12:34
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/de4ebfdc7db6
Gecko Version          34.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150511.033638
Firmware Date          Mon May 11 03:36:49 EDT 2015
Bootloader             L1TC000118D0

Device: Flame2.2 user
Build ID               20150511162500
Gaia Revision          c4c1bf443f2b01c2ba918780510fd4c639a3c360
Gaia Date              2015-05-11 14:12:24
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/70782f19acbf
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150511.195649
Firmware Date          Mon May 11 19:56:59 EDT 2015
Bootloader             L1TC000118D0

Comment 9

[Shine(Leave from Mozilla)]

Attachment: Basque_Zip code.png

Comment 10

[Shine(Leave from Mozilla)]

Attachment: Portuguese Portugal_Zip code.png

Comment 11

[Shine(Leave from Mozilla)]

Attachment: Russian_Zip code.png

Per comment 3, attach the screenshot of Rassian language.

Comment 12

[Delphine Lebédel [:delphine - Use needinfo]]

Fang, any updates on this please? This affects many shipping locales. thanks

Comment 13

[Fang Shih [:fang]]

Attachment: S__19890194.jpg

We do have a new layout to fix this kind of problem. But for the time consuming, I think for now what we can do is to shrink down the text size when strings are displayed with truncation, or we can try abbreviation on the string. ex: código postal change to CP. What do you guys think? 
Thanks!

Comment 14

[Inma Barrios]

Changed to "C. P.", which is the correct abbreviation of "código postal" in Spanish.

Comment 15

[Lancy(Leave from Mozilla)]

Hi Fang,

This issue have been fixed on flame 2.1&2.2 user build in Spanish, but still exist in Polish, Russian, Basque and Portuguese Portugal languages.
Could you help with this issue?
Thank you very much!

Comment 16

[Delphine Lebédel [:delphine - Use needinfo]]

[Blocking Requested - why for this release]:

Seems like this was dropped. Since we're past CC for 2.2, nominating this for 3.0 - in the case that this is still relevant in the upcoming release that we still don't know much about

Comment 18

[Johan Lorenzo [:jlorenzo]]

Comms triage: Blocking as we're not consistent with the truncation sign. Please follow the layout proposed in comment 13.

Comment 19

[Francisco Jordano [:arcturus] [:francisco]]

Solution for this will be doing the ellipsis until we can have a redesign of the whole form.

Comment 20

[Fang Shih [:fang]]

I agree, for now we can use the ellipsis. I've designed a new layout for this contact view that will slove the string trunction problem. Thanks

Comment 21

[GitHub Autolander Bot]

Attachment: [gaia] ferjm:bug1157172.zipcodetruncation > mozilla-b2g:master

Comment 22

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8654778 [details] [review]
[gaia] ferjm:bug1157172.zipcodetruncation > mozilla-b2g:master

I added the ellipsis to all fields in the contacts form.

Comment 23

[Borja Salguero [:borjasalguero]]

Comment on attachment 8654778 [details] [review]
[gaia] ferjm:bug1157172.zipcodetruncation > mozilla-b2g:master

Please address https://github.com/mozilla-b2g/gaia/pull/31605/files#r38443921 and let me know when ready. Thanks!

Comment 24

[Borja Salguero [:borjasalguero]]

Comment on attachment 8654778 [details] [review]
[gaia] ferjm:bug1157172.zipcodetruncation > mozilla-b2g:master

Thanks!! :)

Comment 25

[Fernando Jiménez Moreno [:ferjm]]

https://github.com/mozilla-b2g/gaia/commit/4d8aeb0c301250f3696dda44a8518c70d9ac196a

Comment 26

[Lancy(Leave from Mozilla)]

Attachment: Polish&Russian&Basque&Portuguese Portugal_Zip code_master.png

Per comment 20 ~ comment 22, the hint text of "Zip code" is displayed with ellipsis in Polish, Russian, Basque and Portuguese Portugal languages now.
See attachment:Polish&Russian&Basque&Portuguese Portugal_Zip code_master.png.

Device: FlameKK master 512mb build:
Build ID               20151124013632
Gaia Revision          ea673b5c4cc19c3daca072691a659c68e4c6937f
Gaia Date              2015-11-23 16:41:08
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/19d89caa664dd9309c796929225ee409df5d1ee4
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151124.005539
Firmware Date          Tue Nov 24 00:55:49 UTC 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0