Closed Bug 1157192 Opened 9 years ago Closed 2 years ago

Make the listener an object

Categories

(Remote Protocol :: Marionette, defect, P3)

Product:
Remote Protocol
Component:
Marionette
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: ato, Unassigned)

References

Details

(Keywords: pi-marionette-server)

This is a follow-up on bug 1153832 that introduced the new dispatching technique to the listener. That patch was quite ugly because it had to explicitly assign listeners to functions so that it could add and remove them to the message manager. We can avoid this if we make the listener an object that implements nsIMessageListener. Turning it into an object would also make it more (unit) testable as it would enable us to make assumptions about the listener's current state.
Assignee: nobody → ato
Status: NEW → ASSIGNED
Keywords: ateam-marionette-server
Depends on: 1426154
OS: Unspecified → All
Priority: -- → P3
Hardware: Unspecified → All
Version: unspecified → Trunk
Not currently working on this, but the recent decision to remove frame scripts from Gecko in favour of an ActorChild model may impact the decision whether to do fix this.
Assignee: ato → nobody
Status: ASSIGNED → NEW
Severity: normal → S3
Product: Testing → Remote Protocol

Frame scripts have been removed. As such this bug is no longer needed.

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.