1157224 - WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80520012: file s:\FireFox\sourceTHREE\widget\windows\WinUtils.cpp

Status: NEW

(Core :: Widget: Win32, defect, P5)

Description

[Maksim Lebedev]

User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:36.0) Gecko/20100101 Firefox/36.0
Build ID: 20150320202338

Steps to reproduce:

Every two minutes I can see in output window new message like:
WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80520012: file s:\FireFox\sourceTHREE\widget\windows\WinUtils.cpp,  line 1381


Actual results:

  nsCOMPtr<nsISimpleEnumerator> entries;
  rv = jumpListCacheDir->GetDirectoryEntries(getter_AddRefs(entries));
  NS_ENSURE_SUCCESS(rv, rv);

That code generates a lot of such messages.
rv is NS_ERROR_FILE_NOT_FOUND. Look's like directory is not exist.


Expected results:

I think good approach is to check existing of directory before getting its entries.

Comment 1

[Ryan Nath [:rnath]]

Hi , I would take this bug.

Comment 2

[Justin [:JW_SoftvisionQA]]

Hello Maksim,

Are you still encountering this issue?

If so, could you please provide more detailed steps for me to reproduce?

Thank you,

Justin

Comment 3

[Maksim Lebedev]

Hi, Justin.

At Nightly, I cannot see such message every two minutes. Looks like something changed.
But code does not contain new checks in that places. So I can provide simple repro step.

1. Run Nightly
2. Remove %BUILD%\tmp\scratch_user\jumpListCache folder

After several minutes such message will be printed into on console.

Comment 4

[Nickolay_Ponomarev]

Brian, since you're the original author of this code (http://hg.mozilla.org/mozilla-central/rev/4ba3fb301ff1 - bug 549472), could you comment if this bug is valid or not? The relevant code is at http://hg.mozilla.org/mozilla-central/annotate/d719ac4bcbec/widget/windows/WinUtils.cpp#l1455

Comment 5

[Brian R. Bondy [:bbondy]]

Sorry I'm not sure if it is valid.

Comment 6

[Maksim Lebedev]

My humble opinion that: at first existing of folder should be checked and only if it is exist entires of this folders should be got. Otherwise we got error and print it to console. If it make sence to decrease count of calls, I think error should not be printed, like a expected behavior.