Closed Bug 1157239 Opened 5 years ago Closed 4 years ago

Give GuardShape a resultTypeSet

Categories

(Core :: JavaScript Engine: JIT, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
This fixes the remaining difference between the protosetter and ownsetter numbers in bug 1157231 comment 0. |this| inside the setter ended up being a GuardShape without a resultTypeSet.
Attachment #8595973 - Flags: review?(hv1989)
There are some other instructions that could use a resultTypeSet. Will post more patches.
Comment on attachment 8595973 [details] [diff] [review]
Patch

Review of attachment 8595973 [details] [diff] [review]:
-----------------------------------------------------------------

This definitely looks correct. I'm wondering if we need to decrease the resultTypeSet if possible?
Attachment #8595973 - Flags: review?(hv1989) → review+
https://hg.mozilla.org/mozilla-central/rev/732869779767
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.