1157254 - Marionette is reporting the Marketplace nav menu as being displayed when it is not

Status: RESOLVED WONTFIX

(Remote Protocol :: Marionette, defect)

Description

[Bob Silverberg [:bsilverberg]]

STR:

1. Open https://marketplace-dev.allizom.org/.
2. Make sure the screen size is small enough to display the "Hamburger" to the left of the rocket icon which is used to open the menu.
3. Find the element with the locator By.TAG_NAME, 'mkt-nav-root', which is the container for the menu that appears when clicking the hamburger.
4. Check is_displayed() on that element.

Expected result: False
Actual result: True

Note that the same thing happens with a menu item, not just the menu container. For example, using the locator By.CSS_SELECTOR, '.mkt-nav--link[title="Home"]', the element returned reports is_displayed() as True even when the menu is closed.

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Replicated with the following on latest Marionette from trunk and nightly Firefox:

from marionette_driver.marionette import Marionette
m = Marionette(bin='/Applications/FirefoxNightly.app/Contents/MacOS/firefox-bin')
m.start_session()
m.navigate('http://marketplace-dev.allizom.org/')
m.set_window_size(500, 1027)
nav = m.find_element('id', 'nav')
nav.is_displayed()  # True when the navigation is not displayed
nav.size  # {u'height': 912, u'width': 260}
nav.location  # {u'x': -260, u'y': 0}

It would appear that Marionette is not checking if the element is outside of the viewport in this case.

Comment 2

[Dave Hunt [:davehunt] [he/him] ⌚BST]

I was sure we had a test for this, but can't see one in http://hg.mozilla.org/mozilla-central/file/570bb53a3e7b/testing/marionette/client/marionette/tests/unit/test_visibility.py

Comment 3

[David Burns :automatedtester]

Closing out B2G related bugs. If these still happen and are valuable, please reopen with details again and how this affects Desktop/Fennec