1157260 - Previously selected request timings are shown if a request without timings is selected

Status: RESOLVED WORKSFORME

(DevTools :: Netmonitor, defect, P3)

Description

[Sami Jaktholm]

Attachment: test-page-with-never-loading-image.html

Steps to reproduce:
1. Open netmonitor
2. Open the attached test page
3. Select the first request in netmonitor i.e. the one for the test page (CTRL+F5 defeats caching)
4. Select the timings tab and wait for the timings to become available
5. Select the request to google.fi:8080

What happens: The timings tab doesn't update. It still shows the timings for the request that was selected first.

What should happen: The timings are cleared when the selection changes to a request that doesn't have timings available.

Comment 1

[seccom]

+1 I have been noticing this issue as well while testing a slow response at my workplace. I would like to see the Timings box cleared when I click on a request with no response.

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Thanks for the report and test case!

I can reproduce it on my machine.

> What should happen: The timings are cleared when the selection changes to a request
> that doesn't have timings available.
Sounds correct to me. The side panel tab needs to be cleared and updated when the timing data are received from the backend.

CustomRequestView._setTimingsInformation() is used to update the side panel timings view.

Honza

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

@sjakthol: I can't reproduce this issue any more (using Firefox 65)
https://www.mozilla.org/en-US/firefox/channel/desktop/#nightly

Can you please re test and let me know if this bug report can be closed?

Thanks for the help!
Honza

Comment 5

[Sami Jaktholm]

A lot has changed in four years. I believe this can indeed be closed.

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Thanks for the update!
Honza