Closed
Bug 1157405
Opened 9 years ago
Closed 9 years ago
Bugzilla.parameters is not accessible when requirelogin = 1 and the user is not logged in
Categories
(Bugzilla :: WebService, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 4.4
People
(Reporter: LpSolit, Assigned: LpSolit)
References
Details
Attachments
(2 files)
|
417 bytes,
patch
|
dkl
:
review+
|
Details | Diff | Splinter Review |
|
1.08 KB,
patch
|
dkl
:
review+
|
Details | Diff | Splinter Review |
Bugzilla.parameters is listed in LOGIN_EXEMPT (means it can bypass the requirelogin parameter), but as we call Bugzilla->login() from there, we are shooting ourselves in the foot as Bugzilla will catch that and reject the access with: You must log in before using this part of Bugzilla. (error 410) So we should either call Bugzilla->login(LOGIN_OPTIONAL) or Bugzilla->user instead.
|
Assignee | |
Comment 1•9 years ago
|
||
|
|
Assignee | |
Comment 2•9 years ago
|
||
I just realized that master has all its WS code duplicated in API/. What a pain.
Attachment #8596181 -
Flags: review?(dkl)
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8596173 -
Attachment description: patch, v1 → patch for 4.4 and 5.0, v1
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8596173 [details] [diff] [review] patch for 4.4 and 5.0, v1 Review of attachment 8596173 [details] [diff] [review]: ----------------------------------------------------------------- r=dkl
Attachment #8596173 -
Flags: review?(dkl) → review+
|
|
||
Comment 4•9 years ago
|
||
Comment on attachment 8596181 [details] [diff] [review] patch for master, v1 Review of attachment 8596181 [details] [diff] [review]: ----------------------------------------------------------------- r=dkl
Attachment #8596181 -
Flags: review?(dkl) → review+
|
|
||
Updated•9 years ago
|
Flags: approval?
Flags: approval5.0?
Flags: approval4.4?
Flags: approval?
Flags: approval5.0?
Flags: approval5.0+
Flags: approval4.4?
Flags: approval4.4+
Flags: approval+
|
|
Assignee | |
Comment 5•9 years ago
|
||
To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git 59b3d54..c698db3 master -> master To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git 3fdf31b..9333dc1 5.0 -> 5.0 To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git ea30806..3a21f12 4.4 -> 4.4
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•