1157413 - [gtk3] toolkit/xre/nsAppRunner.cpp: undefined reference to `gtk_window_set_auto_startup_notification'

Status: RESOLVED DUPLICATE of bug 1158154

(Core :: General, defect)

Description

[Jan Beich]

Attachment: Add stub to mozgtk in order to unbreak GTK3 build after bug 1155943

gtk3 build cannot use gtk symbols directly in order to allow mixing with gtk2 plugins (see bug 624422). One has to pass them through mozgtk.

ipc/glue/Unified_cpp_ipc_glue0.o: In function `mozilla::CrossProcessMutex::CrossProcessMutex(char const*)':
ipc/glue/Unified_cpp_ipc_glue0.cpp:(.text._ZN7mozilla17CrossProcessMutexC2EPKc+0x197): warning: warning: mktemp() possibly used unsafely; consider using mkstemp()
xre/nsAppRunner.o: In function `XREMain::XRE_mainStartup(bool*)':
toolkit/xre/nsAppRunner.cpp:(.text._ZN7XREMain15XRE_mainStartupEPb+0x75b): undefined reference to `gtk_window_set_auto_startup_notification'
c++: error: linker command failed with exit code 1 (use -v to see invocation)

Comment 1

[Jan Beich]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=67ac05578edb

Comment 2

[Jan Beich]

Oops, that was pointless. mozgtk isn't built with gtk2 builds.

  $ fgrep -C1 mozgtk widget/gtk/moz.build
  if CONFIG['MOZ_ENABLE_GTK3']:
      DIRS += ['mozgtk']

gtk3: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3454524b406a

Comment 3

[Karl Tomlinson (:karlt)]

Comment on attachment 8596126 [details] [diff] [review]
Add stub to mozgtk in order to unbreak GTK3 build after bug 1155943

Thanks.  Please move STUB(gtk_window_set_auto_startup_notification) to the "#ifdef COMMON_SYMBOLS" block.  It may work as long as the plugin container doesn't call this symbol, but this stub is not needed when mozgtk2 is built because gtk 2 provides this symbol.

Comment 4

[Jan Beich]

Attachment: v2

(In reply to Karl Tomlinson (:karlt) from comment #3)
> Please move STUB(gtk_window_set_auto_startup_notification) to the
> "#ifdef COMMON_SYMBOLS" block.

Actually, I did intend to put it there. Thanks for noticing. With the quoted fix carrying over r+.

gtk3: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0b47856777bd

Comment 6

[Nicolas Silva [:nical]]

Oops, apologies, Lee and I just ran into this issue, filed bug 1158154 and checked the same fix in without noticing this bug.
Sorry about the duplicated effort.

Comment 7

[Jan Beich]

That bug sure landed fast while breaking sorting within the file.