115747 - NS_THEME_TREEVIEW* implementations (Mac)

Status: RESOLVED FIXED

(Core Graveyard :: Skinability, enhancement, P1)

Description

[Hixie (not reading bugmail)]

This covers the implementation of NS_THEME_TREEVIEW, NS_THEME_TREEVIEW_TREEITEM,
NS_THEME_TREEVIEW_TWISTY, NS_THEME_TREEVIEW_LINE, NS_THEME_TREEVIEW_HEADER,
NS_THEME_TREEVIEW_HEADER_CELL and NS_THEME_TREEVIEW_HEADER_SORTARROW for XUL
tree views on Mac.

Comment 1

[Mike Pinkerton (not reading bugmail)]

-> 099

Comment 2

[Mike Pinkerton (not reading bugmail)]

Attachment: trees, tabs, and twisties, oh my!

trees, tabs, twisties.

Comment 3

[Mike Pinkerton (not reading bugmail)]

needing r/sr here. hyatt? smfr?

Comment 4

[Mike Pinkerton (not reading bugmail)]

Attachment: better twisty drawing

fix up twisties so that they have an empty eraseproc and don't blit over the
highlight color of a row.

r/sr needed

Comment 5

[Steve Dagley]

Comment on attachment 66904 [details] [diff] [review]
better twisty drawing

r=sdagley

Comment 6

[David Hyatt]

sr=hyatt

Comment 7

[Simon Fraser [no longer active]]

+static pascal void
+DoNothing(const Rect *bounds, UInt32 eraseData, SInt16 depth, Boolean 
isColorDev)

This could be a static method of the class. Minor.

+  nsCAutoString mode;
+  if ( GetAttribute(aFrame, mSortDirectionAtom, mode) )
+    return strlen(mode.get()) > 0;

strlen(mode.get() ? Use !mode.IsEmpty();

+  nsCAutoString mode;
+  if ( GetAttribute(aFrame, mSortDirectionAtom, mode) )
+    return strcmp(mode.get(), "descending") == 0;

mode.Equal()?

+  nsCAutoString mode;
+  if ( GetAttribute(aFrame, mClassAtom, mode) )
+    return strstr(mode.get(), "tab-bottom") != nsnull;

mode.FindMumble?

Deferring to hyatt on the outliner and CSS changes.

Comment 8

[Mike Pinkerton (not reading bugmail)]

Attachment: address smfr's string comments

Comment 9

[Simon Fraser [no longer active]]

Comment on attachment 66910 [details] [diff] [review]
address smfr's string comments

sr=sfraser

Comment 10

[Mike Pinkerton (not reading bugmail)]

landed.