Closed Bug 115747 Opened 20 years ago Closed 20 years ago

NS_THEME_TREEVIEW* implementations (Mac)

Categories

(Core Graveyard :: Skinability, enhancement, P1)

PowerPC
macOS
enhancement

Tracking

(Not tracked)

RESOLVED FIXED
mozilla0.9.9

People

(Reporter: ian, Assigned: mikepinkerton)

References

Details

Attachments

(1 file, 2 obsolete files)

This covers the implementation of NS_THEME_TREEVIEW, NS_THEME_TREEVIEW_TREEITEM,
NS_THEME_TREEVIEW_TWISTY, NS_THEME_TREEVIEW_LINE, NS_THEME_TREEVIEW_HEADER,
NS_THEME_TREEVIEW_HEADER_CELL and NS_THEME_TREEVIEW_HEADER_SORTARROW for XUL
tree views on Mac.
Summary: NS_THEME_TREEVIEW* implementation (Mac) → NS_THEME_TREEVIEW* implementations (Mac)
-> 099
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.9
Blocks: 117584
QA Contact: pmac
trees, tabs, twisties.
needing r/sr here. hyatt? smfr?
Priority: -- → P1
Attached patch better twisty drawing (obsolete) — Splinter Review
fix up twisties so that they have an empty eraseproc and don't blit over the
highlight color of a row.

r/sr needed
Attachment #66885 - Attachment is obsolete: true
Comment on attachment 66904 [details] [diff] [review]
better twisty drawing

r=sdagley
Attachment #66904 - Flags: review+
sr=hyatt
+static pascal void
+DoNothing(const Rect *bounds, UInt32 eraseData, SInt16 depth, Boolean 
isColorDev)

This could be a static method of the class. Minor.

+  nsCAutoString mode;
+  if ( GetAttribute(aFrame, mSortDirectionAtom, mode) )
+    return strlen(mode.get()) > 0;

strlen(mode.get() ? Use !mode.IsEmpty();

+  nsCAutoString mode;
+  if ( GetAttribute(aFrame, mSortDirectionAtom, mode) )
+    return strcmp(mode.get(), "descending") == 0;

mode.Equal()?

+  nsCAutoString mode;
+  if ( GetAttribute(aFrame, mClassAtom, mode) )
+    return strstr(mode.get(), "tab-bottom") != nsnull;

mode.FindMumble?

Deferring to hyatt on the outliner and CSS changes.
Attachment #66904 - Attachment is obsolete: true
Comment on attachment 66910 [details] [diff] [review]
address smfr's string comments

sr=sfraser
Attachment #66910 - Flags: superreview+
landed.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.