NS_THEME_TAB and NS_THEME_TAB_PANEL implementations (Windows)

RESOLVED FIXED in mozilla0.9.8

Status

Core Graveyard
Skinability
--
enhancement
RESOLVED FIXED
17 years ago
4 years ago

People

(Reporter: Hixie (not reading bugmail), Assigned: David Hyatt)

Tracking

Trunk
mozilla0.9.8
x86
Windows XP
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

4.33 KB, patch
Brian Ryner (not reading)
: review+
Blake Ross
: superreview+
Details | Diff | Splinter Review
(Reporter)

Description

17 years ago
This covers the implementation of NS_THEME_TAB and NS_THEME_TAB_PANEL for XUL
tab panels on Windows.
(Reporter)

Updated

17 years ago
Blocks: 40270
(Reporter)

Updated

17 years ago
Blocks: 40269
(Reporter)

Updated

17 years ago
Blocks: 117584
(Assignee)

Comment 1

17 years ago
Created attachment 63620 [details] [diff] [review]
Patch to add support for tabs.

This patch adds support for tabs.  It doesn't yet cover tabpanels, because I
have to write some custom code to handle not drawing a line under the tab
itself.

A known issue is called out in the bug, namely that I have no way of knowing
how thick the "edges" of tabs are, since all of the skins I tried don't
properly return content margins.  This means I'm forced to make an unfortunate
assumption about the thickness of an edge (namely that the edge of a tab is 2
pixels thick).
(Assignee)

Comment 2

17 years ago
IMO the skins themselves are buggy here, but since they're all behaving this 
way (probably following a bad pattern set by Luna), there isn't much I can do.
(Assignee)

Updated

17 years ago
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.8

Updated

17 years ago
QA Contact: pmac

Comment 3

17 years ago
Comment on attachment 63620 [details] [diff] [review]
Patch to add support for tabs.

sr=blake
Attachment #63620 - Flags: superreview+
Comment on attachment 63620 [details] [diff] [review]
Patch to add support for tabs.

r=bryner
Attachment #63620 - Flags: review+
(Assignee)

Comment 5

17 years ago
Fix checked in.  Now all I have left is the tab panel.

(Assignee)

Updated

17 years ago
Attachment #63620 - Attachment is obsolete: true
(Assignee)

Comment 6

17 years ago
Created attachment 63691 [details] [diff] [review]
Patch to add support for tabpanels.

Tabpanels support.  Known issues: handling not drawing the line under the
selected tab, line needs to overlap tabs by one pixel in order to be
pixel-perfect, and finally no way to specify a tabpanel (which isn't really a
big deal, the style builder doesn't even show you this as a separate entity in
the widget display).
Comment on attachment 63691 [details] [diff] [review]
Patch to add support for tabpanels.

r=bryner
Attachment #63691 - Flags: review+

Comment 8

17 years ago
Comment on attachment 63691 [details] [diff] [review]
Patch to add support for tabpanels.

sr=blake
Attachment #63691 - Flags: superreview+
(Assignee)

Comment 9

17 years ago
Ok, marking this fixed.  Will file separate bugs for the remaining drawing issue.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
david,

did this fix cause bug 118471 to be exposed?

Updated

16 years ago
Blocks: 185435
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.