Closed Bug 1157509 Opened 9 years ago Closed 9 years ago

fx desktop build script fails with mazharness disabled (trying to update mock environment)

Categories

(Release Engineering :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: mrrrgn, Assigned: mrrrgn)

References

Details

Attachments

(1 file)

17:25:04    FATAL - Uncaught exception: Traceback (most recent call last):
17:25:04    FATAL -   File "/shared/mozharness/mozharness/base/script.py", line 1288, in run
17:25:04    FATAL -     self.run_action(action)
17:25:04    FATAL -   File "/shared/mozharness/mozharness/base/script.py", line 1230, in run_action
17:25:04    FATAL -     self._possibly_run_method(method_name, error_if_missing=True)
17:25:04    FATAL -   File "/shared/mozharness/mozharness/base/script.py", line 1171, in _possibly_run_method
17:25:04    FATAL -     return getattr(self, method_name)()
17:25:04    FATAL -   File "/shared/mozharness/mozharness/mozilla/building/buildbase.py", line 1514, in build
17:25:04    FATAL -     env.update(self.query_mach_build_env())
17:25:04    FATAL -   File "/shared/mozharness/mozharness/mozilla/building/buildbase.py", line 819, in query_mach_build_env
17:25:04    FATAL -     'stage_server': c['stage_server']

This can be solved by not running query_mach_build_env when mock is disabled.
Assignee: nobody → winter2718
Blocks: 1135206
Attachment #8596266 - Flags: review?(jlund)
Comment on attachment 8596266 [details] [diff] [review]
query-mock-env.diff

Review of attachment 8596266 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozharness/mozilla/building/buildbase.py
@@ +1506,5 @@
>      def build(self):
>          """builds application."""
>          env = self.query_build_env()
> +        if self.mock_enabled:
> +            env.update(self.query_mach_build_env())

query_mach_build_env sets the environment for 'mach build'. mach (not to be confused with our chroot mock) is a Mozilla python command line solution for helping developers perform common tasks. We use it in automation as our entry point for compiling builds. We need query_mach_build_env() to set the vars required for this.

Which env var(s) getting set here are breaking your build?
Attachment #8596266 - Flags: review?(jlund) → review-
(In reply to Jordan Lund (:jlund) from comment #2)
> Comment on attachment 8596266 [details] [diff] [review]
> query-mock-env.diff
> 
> Review of attachment 8596266 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: mozharness/mozilla/building/buildbase.py
> @@ +1506,5 @@
> >      def build(self):
> >          """builds application."""
> >          env = self.query_build_env()
> > +        if self.mock_enabled:
> > +            env.update(self.query_mach_build_env())
> 
> query_mach_build_env sets the environment for 'mach build'. mach (not to be
> confused with our chroot mock) is a Mozilla python command line solution for
> helping developers perform common tasks. We use it in automation as our
> entry point for compiling builds. We need query_mach_build_env() to set the
> vars required for this.
> 
> Which env var(s) getting set here are breaking your build?

This is what I get for trying to debug things during a meeting: major derp. I can just stub out the missing variables, no problem. Sorry for the spam!
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → INVALID
Component: Tools → General
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: