115753 - NS_THEME_TOOLTIP implementation (Windows)

Status: RESOLVED FIXED

(Core Graveyard :: Skinability, enhancement)

Description

[Hixie (not reading bugmail)]

This covers the implementation of NS_THEME_TOOLTIP for XUL and HTML tooltips on
Windows.

Comment 1

[Blake Ross]

Attachment: patch: basic tooltip support (untested)

Comment 2

[Blake Ross]

Okay, so by the time someone applied and tested this, they could have written 
it. Shut up, I'm just getting my feet wet :)

Comment 3

[David Hyatt]

BP_NORMAL and the three other generic states (hover/active/disabled) should be
renamed to a generic constant, e.g., TS_NORMAL (theme state normal), and that
should just be used rather than TSS_NORMAL and BP_NORMAL.

Comment 4

[David Hyatt]

Attachment: Tested patch (merged in with current tip).

Here it is cleaned up and tested.  It works, although you don't get the sexy
drop shadows on popups.  I need to figure out how we can just automatically put
drop shadows on popup windows.

Comment 5

[Brian Ryner (not reading)]

Comment on attachment 63600 [details] [diff] [review]
Tested patch (merged in with current tip).

r=bryner

Comment 6

[(not reading, please use [e-mail] instead)]

Comment on attachment 63600 [details] [diff] [review]
Tested patch (merged in with current tip).

sr=sspitzer

Comment 7

[David Hyatt]

Fixed.

Comment 8

[Hixie (not reading bugmail)]

http://msdn.microsoft.com/library/default.asp?url=/library/en-us/winui/winclass_3b1v.asp

Basically, you use RegisterClassEx() to register a class that has WNDCLASSEX
struct with its |style| member having the CS_DROPSHADOW flag set, then you use
CreateWindowEx() and pass it the atom returned by RegisterClassEx() representing
the window style you registered.

Comment 9

[David Hyatt]

Yes, that worked like a charm.  I'm breaking out the dropshadow stuff into a
separate bug.