1157573 - Intermittent test_clearHistory_shutdown.js | application crashed [@ mozilla::dom::indexedDB::`anonymous namespace'::DatabaseConnection::FinishWriteTransaction()]

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect)

Comment 1

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=9206288
repository: mozilla-inbound
start_time: 2015-04-22T19:52:10
who: philringnalda[at]gmail[dot]com
machine: t-xp32-ix-136
buildname: Windows XP 32-bit mozilla-inbound debug test xpcshell
revision: 9d2b8afeb3b4

TEST-UNEXPECTED-FAIL | browser/components/places/tests/unit/test_clearHistory_shutdown.js | xpcshell return code: 1
PROCESS | 192 | Assertion failure: mDEBUGInWriteTransaction, at c:/builds/moz2_slave/m-in-w32-d-0000000000000000000/build/src/dom/indexedDB/ActorsParent.cpp:8465
PROCESS-CRASH | browser/components/places/tests/unit/test_clearHistory_shutdown.js | application crashed [@ mozilla::dom::indexedDB::`anonymous namespace'::DatabaseConnection::FinishWriteTransaction()]
Return code: 1

Comment 2

[Marco Bonardo [:mak]]

Even if the test is in places folder, it's an assertion in indexedDB

19:16:31 INFO - PROCESS | 192 | [192] WARNING: 'QuotaClient::IsShuttingDownOnNonMainThread()', file c:/builds/moz2_slave/m-in-w32-d-0000000000000000000/build/src/dom/indexedDB/ActorsParent.cpp, line 18258
19:16:31 INFO - "CONSOLE_MESSAGE: (warn) [JavaScript Error: "IndexedDB UnknownErr: ActorsParent.cpp:18260"]"
19:16:31 INFO - "CONSOLE_MESSAGE: (warn) [JavaScript Error: "IndexedDB UnknownErr: ActorsParent.cpp:11511"]"
19:16:31 INFO - "CONSOLE_MESSAGE: (warn) [JavaScript Error: "UnknownError"]"
19:16:31 INFO - PROCESS | 192 | Assertion failure: mDEBUGInWriteTransaction, at c:/builds/moz2_slave/m-in-w32-d-0000000000000000000/build/src/dom/indexedDB/ActorsParent.cpp:8465
19:16:31 INFO - PROCESS | 192 | [192] WARNING: 'quotaClient->IsShuttingDown()', file c:/builds/moz2_slave/m-in-w32-d-0000000000000000000/build/src/dom/indexedDB/ActorsParent.cpp, line 17140
19:16:31 INFO - PROCESS | 192 | [192] WARNING: 'NS_FAILED(rv)', file c:/builds/moz2_slave/m-in-w32-d-0000000000000000000/build/src/dom/indexedDB/ActorsParent.cpp, line 17056
19:16:31 INFO - "CONSOLE_MESSAGE: (warn) [JavaScript Error: "IndexedDB UnknownErr: ActorsParent.cpp:17141"]"
19:16:31 INFO - "CONSOLE_MESSAGE: (warn) [JavaScript Error: "UnknownError"]"

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v1

This is mostly just a DEBUG fix, but there's a chance without it we could get a connection stuck for a while in a slower mode where it's creating an implicit transaction for every request.

Comment 4

[Jan Varga [:janv]]

Comment on attachment 8596777 [details] [diff] [review]
Patch, v1

Review of attachment 8596777 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

Comment 5

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=9251032
repository: mozilla-inbound
start_time: 2015-04-23T13:51:53
who: wkocher[at]mozilla[dot]com
machine: t-w732-ix-127
buildname: Windows 7 32-bit mozilla-inbound debug test xpcshell
revision: 1898f6872faa

TEST-UNEXPECTED-FAIL | dom/push/test/xpcshell/test_notification_incomplete.js | xpcshell return code: 1
PROCESS | 8836 | Assertion failure: mDEBUGInWriteTransaction, at c:/builds/moz2_slave/m-in-w32-d-0000000000000000000/build/src/dom/indexedDB/ActorsParent.cpp:8465
PROCESS-CRASH | dom/push/test/xpcshell/test_notification_incomplete.js | application crashed [@ mozilla::dom::indexedDB::`anonymous namespace'::DatabaseConnection::FinishWriteTransaction()]
Return code: 1

Comment 6

[Ben Turner (not reading bugmail, use the needinfo flag!)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/529db1452e1e

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/529db1452e1e

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Was this fallout from bug 1156063?

Comment 9

[Ben Turner (not reading bugmail, use the needinfo flag!)]

No, bug 1131766.

Comment 10

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=10928927
repository: mozilla-inbound
start_time: 2015-06-18T06:22:25
who: tomcat[at]mozilla[dot]com
machine: t-snow-r4-0091
buildname: Rev4 MacOSX Snow Leopard 10.6 mozilla-inbound debug test xpcshell
revision: a7519734ac5b

TEST-UNEXPECTED-FAIL | browser/components/places/tests/unit/test_clearHistory_shutdown.js | xpcshell return code: 1
PROCESS | 9099 | Assertion failure: !mInReadTransaction, at /builds/slave/m-in-m64-d-0000000000000000000/build/src/dom/indexedDB/ActorsParent.cpp:8965
PROCESS-CRASH | browser/components/places/tests/unit/test_clearHistory_shutdown.js | application crashed [@ mozilla::dom::indexedDB::(anonymous namespace)::TransactionBase::CommitOp::Run()]
Return code: 1

Comment 11

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=fx-team&job_id=3593093
repository: fx-team
start_time: 2015-06-29T06:50:03
who: tomcat[at]mozilla[dot]com
machine: t-snow-r4-0013
buildname: Rev4 MacOSX Snow Leopard 10.6 fx-team debug test xpcshell
revision: 5310abba869f

TEST-UNEXPECTED-FAIL | browser/components/places/tests/unit/test_clearHistory_shutdown.js | xpcshell return code: 1
PROCESS | 5129 | Assertion failure: !mInReadTransaction, at /builds/slave/fx-team-m64-d-0000000000000000/build/src/dom/indexedDB/ActorsParent.cpp:8971
PROCESS-CRASH | browser/components/places/tests/unit/test_clearHistory_shutdown.js | application crashed [@ mozilla::dom::indexedDB::(anonymous namespace)::TransactionBase::CommitOp::Run()]
Return code: 1