1157646 - Stop passing the roomOwner parameter around everywhere in rooms

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Mark Banner (:standard8)]

Currently we're requiring and passing the roomOwner parameter around in various places when we don't actually use it.

We should remove it from:

- activeRoomStore
- standaloneMozLoop (the get of room information)
- The test files associated with the above two items.

Comment 1

[Mark Banner (:standard8)]

Attachment: Stop passing the roomOwner parameter around everywhere in Loop's rooms.

I decided to pick this up as part of bug 1198421, as otherwise I'm just going to be adding more redundant roomOwner options.

I've left the roomOwner stuff in the chrome backend modules - some of it we need, some of it seems to make sense to keep for now, as the server is still sending roomOwner info.

Comment 2

[Mark Banner (:standard8)]

P1 as this is needed for bug 1198421

Comment 3

[Mike de Boer [:mikedeboer]]

Comment on attachment 8652809 [details] [diff] [review]
Stop passing the roomOwner parameter around everywhere in Loop's rooms.

Review of attachment 8652809 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the delay, this was actually super easy to review! :-S

Thanks!

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/4722e298ea31

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4722e298ea31