Stop passing the roomOwner parameter around everywhere in rooms

RESOLVED FIXED in Firefox 43

Status

defect
P1
normal
Rank:
19
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

unspecified
mozilla43
Points:
2
Dependency tree / graph
Bug Flags:
firefox-backlog +
in-testsuite +
qe-verify -

Firefox Tracking Flags

(firefox43 fixed)

Details

(Whiteboard: [tech-debt])

Attachments

(1 attachment)

Currently we're requiring and passing the roomOwner parameter around in various places when we don't actually use it.

We should remove it from:

- activeRoomStore
- standaloneMozLoop (the get of room information)
- The test files associated with the above two items.
I decided to pick this up as part of bug 1198421, as otherwise I'm just going to be adding more redundant roomOwner options.

I've left the roomOwner stuff in the chrome backend modules - some of it we need, some of it seems to make sense to keep for now, as the server is still sending roomOwner info.
Attachment #8652809 - Flags: review?(mdeboer)
Assignee: nobody → standard8
Blocks: 1198421
Iteration: --- → 43.2 - Sep 7
P1 as this is needed for bug 1198421
Rank: 19
Priority: -- → P1
Flags: qe-verify-
Flags: firefox-backlog+
Comment on attachment 8652809 [details] [diff] [review]
Stop passing the roomOwner parameter around everywhere in Loop's rooms.

Review of attachment 8652809 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the delay, this was actually super easy to review! :-S

Thanks!
Attachment #8652809 - Flags: review?(mdeboer) → review+
https://hg.mozilla.org/mozilla-central/rev/4722e298ea31
Status: NEW → RESOLVED
Closed: 4 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.