Closed
Bug 1157654
Opened 10 years ago
Closed 10 years ago
Intermittent test_mediarecorder_getencodeddata.html | onStop after onError - expected PASS
Categories
(Core :: Audio/Video: Recording, defect)
Tracking
()
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox38 | --- | unaffected |
firefox38.0.5 | --- | unaffected |
firefox39 | --- | unaffected |
firefox40 | --- | fixed |
firefox-esr31 | --- | unaffected |
firefox-esr38 | --- | unaffected |
People
(Reporter: cbook, Assigned: bechen)
References
()
Details
(Keywords: intermittent-failure)
Attachments
(1 file, 1 obsolete file)
2.09 KB,
patch
|
bechen
:
review+
|
Details | Diff | Splinter Review |
Windows XP 32-bit mozilla-inbound opt test mochitest-3
https://treeherder.mozilla.org/logviewer.html#?job_id=9220693&repo=mozilla-inbound
02:47:16 INFO - 338 INFO TEST-UNEXPECTED-FAIL | dom/media/test/test_mediarecorder_getencodeddata.html | onStop after onError - expected PASS
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Updated•10 years ago
|
Component: DOM → Video/Audio
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment 25•10 years ago
|
||
This is pretty frequent. Can we get some eyes on this please? :)
Flags: needinfo?(jwwang)
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Pretty clearly caused by something in this push:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?changeset=914fd1f2d882
I plan to back out the three changesets by Benjamin Chen in that push unless I can quickly eliminate some of them as potential causes of this.
Comment 49•10 years ago
|
||
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment 56•10 years ago
|
||
Hi Benjamin,
Please check this out. Thanks.
Assignee: nobody → bechen
Flags: needinfo?(jwwang)
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Assignee | ||
Comment 60•10 years ago
|
||
I think I figure out why the testcase failed even though I can not reproduce it.
Because the InitEncoder() is not called yet from TracksAvailableCallback, so the Session::Stop function call DoSessionEndTask(NS_OK). Since the NS_OK won't notify the error to JS cause the testcase failed.
Before bug 1153690, the InitEncoder() will trigger the DoSessionEndTask(NS_ERROR_ABORT) to notify the error.
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Assignee | ||
Comment 84•10 years ago
|
||
For the testcase modification, apply the patch of bug 1153690, if we call MediaRecorder.stop immediately after the MediaReocrder.start, it won't gaurantee the onerror callback will be invoked because the TracksAvailableCallback might not be called (See bug 1153690 comment 8). So I remove the MediaRecorder.stop to make sure we will receive the onerror callback.
For the MediaReocrder modification, I think it is better if we make the NotifyError asynchronous, if the MediaReocrder::NotifyError is a sync call, the testcase will fail if we add MediaRecorder.stop in onerror callback. (It is trivial to call stop if we receive an onerror callback)
Assignee | ||
Updated•10 years ago
|
Attachment #8598530 -
Flags: review?(roc)
Attachment #8598530 -
Flags: review?(roc) → review+
Assignee | ||
Comment 85•10 years ago
|
||
r=roc
try server with bug 1153690:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f4e9b86ea695
try server:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=cb62f41750a3
Attachment #8598530 -
Attachment is obsolete: true
Attachment #8599767 -
Flags: review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 86•10 years ago
|
||
Keywords: checkin-needed
Comment 87•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox40:
--- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Updated•10 years ago
|
status-firefox38:
--- → unaffected
status-firefox38.0.5:
--- → unaffected
status-firefox39:
--- → unaffected
status-firefox-esr31:
--- → unaffected
status-firefox-esr38:
--- → unaffected
You need to log in
before you can comment on or make changes to this bug.
Description
•