1157663 - Uninitialized members in mozilla::layers::TextRenderer constructor

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Nicolas Silva [:nical]]

mMap is not initialized in the constructor. In practice the code is correct because we never call read from mMap without calling EnsureIntialized, but it contributres to the coverity warning noise and half initialized structures are generally a bad idea, so let's fix it.

Comment 1

[Baptiste Emmanuel]

Hi,

I would like to work on this bug. First contribution

Comment 2

[Baptiste Emmanuel]

Quick question. Do I have to take the code inside EnsureIntialized and put it in the constructor or just initialized mMap to something else.

Comment 3

[Nicolas Silva [:nical]]

(In reply to Baptiste Emmanuel from comment #2)
> Quick question. Do I have to take the code inside EnsureIntialized and put
> it in the constructor or just initialized mMap to something else.

Initializing it with mData = nullptr and mStride = 0 is enough.

Comment 4

[Baptiste Emmanuel]

Attachment: textrender.constructor.v1.patch

Comment 5

[Carsten Book [:Tomcat]]

can we get a try run for this, thanks!

Comment 6

[Paul Adenot (:padenot)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f60ff9177143

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/26b9e4567122

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/26b9e4567122