Closed
Bug 1157663
Opened 8 years ago
Closed 8 years ago
Uninitialized members in mozilla::layers::TextRenderer constructor
Categories
(Core :: Graphics: Layers, defect)
Core
Graphics: Layers
Tracking
()
RESOLVED
FIXED
mozilla41
Tracking | Status | |
---|---|---|
firefox41 | --- | fixed |
People
(Reporter: nical, Assigned: baptiste.em, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: coverity, Whiteboard: [gfx-noted])
Attachments
(1 file)
1.04 KB,
patch
|
nical
:
review+
|
Details | Diff | Splinter Review |
mMap is not initialized in the constructor. In practice the code is correct because we never call read from mMap without calling EnsureIntialized, but it contributres to the coverity warning noise and half initialized structures are generally a bad idea, so let's fix it.
Assignee | ||
Comment 1•8 years ago
|
||
Hi, I would like to work on this bug. First contribution
Reporter | ||
Updated•8 years ago
|
Assignee: nobody → baptiste.em
Assignee | ||
Comment 2•8 years ago
|
||
Quick question. Do I have to take the code inside EnsureIntialized and put it in the constructor or just initialized mMap to something else.
Reporter | ||
Comment 3•8 years ago
|
||
(In reply to Baptiste Emmanuel from comment #2) > Quick question. Do I have to take the code inside EnsureIntialized and put > it in the constructor or just initialized mMap to something else. Initializing it with mData = nullptr and mStride = 0 is enough.
Assignee | ||
Comment 4•8 years ago
|
||
Attachment #8607573 -
Flags: review?(nical.bugzilla)
Reporter | ||
Updated•8 years ago
|
Attachment #8607573 -
Flags: review?(nical.bugzilla) → review+
Updated•8 years ago
|
Keywords: checkin-needed
Comment 5•8 years ago
|
||
can we get a try run for this, thanks!
Flags: needinfo?(baptiste.em)
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/26b9e4567122
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Assignee | ||
Updated•8 years ago
|
Flags: needinfo?(baptiste.em)
Updated•5 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•