Closed Bug 1157663 Opened 6 years ago Closed 6 years ago
Uninitialized members in mozilla::layers::Text
mMap is not initialized in the constructor. In practice the code is correct because we never call read from mMap without calling EnsureIntialized, but it contributres to the coverity warning noise and half initialized structures are generally a bad idea, so let's fix it.
Hi, I would like to work on this bug. First contribution
Quick question. Do I have to take the code inside EnsureIntialized and put it in the constructor or just initialized mMap to something else.
(In reply to Baptiste Emmanuel from comment #2) > Quick question. Do I have to take the code inside EnsureIntialized and put > it in the constructor or just initialized mMap to something else. Initializing it with mData = nullptr and mStride = 0 is enough.
Attachment #8607573 - Flags: review?(nical.bugzilla) → review+
can we get a try run for this, thanks!
You need to log in before you can comment on or make changes to this bug.