115767 - NS_THEME_DROPDOWN* implementations (Windows)

Status: RESOLVED FIXED

(Core Graveyard :: Skinability, enhancement)

Description

[Hixie (not reading bugmail)]

This covers the implementation of NS_THEME_DROPDOWN and NS_THEME_DROPDOWN_BUTTON
on Windows.

Comment 1

[David Hyatt]

Attachment: Menu list patch

Here it is.  Everything works perfectly, except that the dropdown marker is too
skinny.  Not sure why.	I'll look into it.

Comment 2

[Hixie (not reading bugmail)]

Why no hyphens in "menulistbutton"? Shouldn't it be "menu-list-item"? (Similarly
for all the other constants of course.)

Also, we should open a bug about leaf appearances only being supported on XUL
box frames for now. Pity it couldn't be done in a more generic fashion. There's
too much duplication in frame code for my liking already... :-(

r=hixie

Comment 3

[Blake Ross]

Comment on attachment 63716 [details] [diff] [review]
Menu list patch

sr=blake

Comment 4

[Hixie (not reading bugmail)]

Shouldn't check boxes, resizers, progress bar chunks, and scrollbar buttons also
be added to the list of leaf content?

Comment 5

[David Hyatt]

Fixed.  There are issues with the hover feedback on the dropmarker (just as 
with radio buttons and checkboxes).