Closed Bug 1157684 Opened 10 years ago Closed 7 years ago

[metro-removal] Makefile recursion handling can possibly be removed

Categories

(Firefox for Metro Graveyard :: Build Config, defect)

Product:
Firefox for Metro Graveyard
Component:
Build Config
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED INCOMPLETE

People

(Reporter: kats, Unassigned)

References

Details

Bug 1039866 removed much of the metro code from mozilla-central but there were some bits that required more investigation/cleanup. This is one of them. Quoting from bug 1039866 comment 45: >diff --git a/config/recurse.mk b/config/recurse.mk > # The rules here are doing directory traversal, so we don't want further > # recursion to happen when running make -C subdir $tier. But some make files > # further call make -C something else, and sometimes expect recursion to >-# happen in that case (see browser/metro/locales/Makefile.in for example). >+# happen in that case. > # Conveniently, every invocation of make increases MAKELEVEL, so only stop > # recursion from happening at current MAKELEVEL + 1. Was that Metro Makefile the only Makefile that did this? Perhaps we can rip out more of this stuff, or find another example? Separate bug.
Mass close of bugs in obsolete product https://bugzilla.mozilla.org/show_bug.cgi?id=1350354
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.