1157685 - [metro-removal] Remove code related to full-screen-api.content-only=true

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Bug 1039866 removed much of the metro code from mozilla-central but there were some bits that required more investigation/cleanup. This is one of them. Quoting from bug 1039866 comment 45:

>diff --git a/dom/base/nsContentUtils.h b/dom/base/nsContentUtils.h

>    * Making the fullscreen API content only is useful on platforms where we
>    * still want chrome to be visible or accessible while content is
>-   * fullscreen, like on Windows 8 in Metro mode.
>+   * fullscreen.

Looking at this code, Metro seems to be the only thing that sets full-screen-api.content-only=true. So we can probably rip out a bunch more related code. This can be a new bug too.

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

This pref was added for Metro mode to avoid UI hiding itself when the content enters fullscreen. But I don't think it was a good design. Even if one day we want to support Metro again, we should explicitly check that in chrome code, instead of stop propagating the event or something to the chrome. Hence this code should definitely be removed to simplify the logic.

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

Attachment: patch

Roughly a manual backout of http://hg.mozilla.org/mozilla-central/rev/bf9ce076f19d

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8605640 [details] [diff] [review]
patch

odd code.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/733947acb2f7

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/733947acb2f7