Closed Bug 1157685 Opened 5 years ago Closed 5 years ago

[metro-removal] Remove code related to full-screen-api.content-only=true

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: kats, Assigned: xidorn)

References

Details

Attachments

(1 file)

Bug 1039866 removed much of the metro code from mozilla-central but there were some bits that required more investigation/cleanup. This is one of them. Quoting from bug 1039866 comment 45:

>diff --git a/dom/base/nsContentUtils.h b/dom/base/nsContentUtils.h

>    * Making the fullscreen API content only is useful on platforms where we
>    * still want chrome to be visible or accessible while content is
>-   * fullscreen, like on Windows 8 in Metro mode.
>+   * fullscreen.

Looking at this code, Metro seems to be the only thing that sets full-screen-api.content-only=true. So we can probably rip out a bunch more related code. This can be a new bug too.
Component: Build Config → DOM
Product: Firefox for Metro → Core
This pref was added for Metro mode to avoid UI hiding itself when the content enters fullscreen. But I don't think it was a good design. Even if one day we want to support Metro again, we should explicitly check that in chrome code, instead of stop propagating the event or something to the chrome. Hence this code should definitely be removed to simplify the logic.
Assignee: nobody → quanxunzhen
Depends on: 1161802
Attached patch patchSplinter Review
Roughly a manual backout of http://hg.mozilla.org/mozilla-central/rev/bf9ce076f19d
Attachment #8605640 - Flags: review?(bugs)
Comment on attachment 8605640 [details] [diff] [review]
patch

odd code.
Attachment #8605640 - Flags: review?(bugs) → review+
Blocks: 1161802
No longer depends on: 1161802
https://hg.mozilla.org/mozilla-central/rev/733947acb2f7
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.