Various layout reftest failures when Gecko 40 merges to beta

VERIFIED FIXED in Firefox 40

Status

()

Core
Layout
--
major
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: RyanVM, Assigned: jfkthame)

Tracking

Trunk
mozilla40
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox40 verified)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
https://treeherder.mozilla.org/logviewer.html#?job_id=6871116&repo=try


REFTEST TEST-UNEXPECTED-FAIL | file:///builds/slave/test/build/tests/reftest/tests/layout/reftests/css-grid/rtl-grid-placement-definite-001.html | image comparison (==), max difference: 255, number of differing pixels: 76642
REFTEST TEST-UNEXPECTED-FAIL | file:///builds/slave/test/build/tests/reftest/tests/layout/reftests/css-grid/rtl-grid-placement-auto-row-sparse-001.html | image comparison (==), max difference: 255, number of differing pixels: 61719
REFTEST TEST-UNEXPECTED-FAIL | file:///builds/slave/test/build/tests/reftest/tests/layout/reftests/css-grid/vlr-grid-placement-auto-row-sparse-001.html | image comparison (==), max difference: 255, number of differing pixels: 61723
REFTEST TEST-UNEXPECTED-FAIL | file:///builds/slave/test/build/tests/reftest/tests/layout/reftests/css-grid/vrl-grid-placement-auto-row-sparse-001.html | image comparison (==), max difference: 255, number of differing pixels: 61723
REFTEST TEST-UNEXPECTED-FAIL | file:///builds/slave/test/build/tests/reftest/tests/layout/reftests/floats/orthogonal-floats-1a.html | image comparison (==), max difference: 255, number of differing pixels: 13399
REFTEST TEST-UNEXPECTED-FAIL | file:///builds/slave/test/build/tests/reftest/tests/layout/reftests/floats/orthogonal-floats-1b.html | image comparison (==), max difference: 255, number of differing pixels: 13399
REFTEST TEST-UNEXPECTED-FAIL | file:///builds/slave/test/build/tests/reftest/tests/layout/reftests/floats/orthogonal-floats-1c.html | image comparison (==), max difference: 255, number of differing pixels: 18430
REFTEST TEST-UNEXPECTED-FAIL | file:///builds/slave/test/build/tests/reftest/tests/layout/reftests/floats/orthogonal-floats-1d.html | image comparison (==), max difference: 255, number of differing pixels: 18430
Flags: needinfo?(jfkthame)
(Assignee)

Comment 1

3 years ago
Created attachment 8596595 [details] [diff] [review]
Explicitly enable writing-mode support for reftests that require it

Yeah, I realized the other day that we've started to land a few tests that assume writing-mode support outside of the writing-mode subdirectory (which has a default-pref in its manifest); so until the pref is enabled for release channels, we need to explicitly turn it on for these tests, otherwise they'll fail.
Attachment #8596595 - Flags: review?(smontagu)
(Assignee)

Updated

3 years ago
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
(Assignee)

Updated

3 years ago
Flags: needinfo?(jfkthame)
Comment on attachment 8596595 [details] [diff] [review]
Explicitly enable writing-mode support for reftests that require it

Review of attachment 8596595 [details] [diff] [review]:
-----------------------------------------------------------------

So there is nothing between setting a pref on a whole manifest and setting it individually on each test that requires it? Seems that that could be improved, but that's not relevant to this bug.
Attachment #8596595 - Flags: review?(smontagu) → review+
(Reporter)

Comment 5

3 years ago
https://hg.mozilla.org/mozilla-central/rev/4a4c3607809e
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox40: affected → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
(Reporter)

Updated

3 years ago
Status: RESOLVED → VERIFIED
status-firefox40: fixed → verified
You need to log in before you can comment on or make changes to this bug.