1157701 - test_peerConnection_replaceTrack.html is going to permafail when Gecko 40 merges to Aurora

Status: VERIFIED FIXED

(Core :: WebRTC: Audio/Video, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

https://treeherder.mozilla.org/logviewer.html#?job_id=6870717&repo=try

23:29:43 INFO - 1974 INFO Run step 42: PC_REMOTE_VIDEOONLY_REPLACE_VIDEOTRACK
23:29:43 INFO - 1975 INFO TEST-PASS | dom/media/tests/mochitest/test_peerConnection_replaceTrack.html | We have a sender for video
23:29:43 INFO - 1976 INFO TEST-PASS | dom/media/tests/mochitest/test_peerConnection_replaceTrack.html | Shouldn't have any streams without a corresponding sender
23:29:43 INFO - 1977 INFO TEST-PASS | dom/media/tests/mochitest/test_peerConnection_replaceTrack.html | replacing with a different track
23:29:43 INFO - 1978 INFO TEST-UNEXPECTED-FAIL | dom/media/tests/mochitest/test_peerConnection_replaceTrack.html | Error in test execution: TypeError: pc.getLocalStreams(...).includes is not a function replacetest/<@http://mochi.test:8888/tests/dom/media/tests/mochitest/test_peerConnection_replaceTrack.html:38:13 ... Promise*replacetest@http://mochi.test:8888/tests/dom/media/tests/mochitest/test_peerConnection_replaceTrack.html:33:12 ... PC_REMOTE_VIDEOONLY_REPLACE_VIDEOTRACK@http://mochi.test:8888/tests/dom/media/tests/mochitest/test_peerConnection_replaceTrack.html:64:16 ... CommandChain.prototype.execute/</<@http://mochi.test:8888/tests/dom/media/tests/mochitest/head.js:353:31 ... Promise*CommandChain.prototype.execute/<@http://mochi.test:8888/tests/dom/media/tests/mochitest/head.js:351:1 ... CommandChain.prototype.execute@http://mochi.test:8888/tests/dom/media/tests/mochitest/head.js:346:12 ... PeerConnectionTest.prototype.run@http://mochi.test:8888/tests/dom/media/tests/mochitest/pc.js:476:10 ... @http://mochi.test:8888/tests/dom/media/tests/mochitest/test_peerConnection_replaceTrack.html:169:5 ... runNetworkTest/</</<@http://mochi.test:8888/tests/dom/media/tests/mochitest/pc.js:1878:21 ... Promise*startNetworkAndTest@http://mochi.test:8888/tests/dom/media/tests/mochitest/network.js:102:1 ... runNetworkTest/</<@http://mochi.test:8888/tests/dom/media/tests/mochitest/pc.js:1877:7 ... runTestWhenReady/</<@http://mochi.test:8888/tests/dom/media/tests/mochitest/head.js:168:45 ... Promise*@http://mochi.test:8888/tests/dom/media/tests/mochitest/head.js:121:22 ... - expected PASS
23:29:43 INFO - 1979 INFO TEST-FAIL | dom/media/tests/mochitest/test_peerConnection_replaceTrack.html | The author of the test has indicated that flaky timeouts are expected. Reason: WebRTC inherently depends on timeouts
23:29:43 INFO - 1980 INFO Closing peer connections

23:30:34 INFO - 2129 INFO Run step 54: CHECK_AUDIO_FLOW
23:30:34 INFO - 2130 INFO TEST-UNEXPECTED-FAIL | dom/media/tests/mochitest/test_peerConnection_webAudio.html | Error in test execution: TypeError: inputSenderTracks.includes is not a function PeerConnectionWrapper.prototype.checkReceivingToneFrom/inputAudioStream</<@http://mochi.test:8888/tests/dom/media/tests/mochitest/pc.js:1549:47 ... PeerConnectionWrapper.prototype.checkReceivingToneFrom/inputAudioStream<@http://mochi.test:8888/tests/dom/media/tests/mochitest/pc.js:1549:18 ... PeerConnectionWrapper.prototype.checkReceivingToneFrom@http://mochi.test:8888/tests/dom/media/tests/mochitest/pc.js:1548:28 ... CHECK_AUDIO_FLOW@http://mochi.test:8888/tests/dom/media/tests/mochitest/test_peerConnection_webAudio.html:35:14 ... CommandChain.prototype.execute/</<@http://mochi.test:8888/tests/dom/media/tests/mochitest/head.js:353:31 ... Promise*CommandChain.prototype.execute/<@http://mochi.test:8888/tests/dom/media/tests/mochitest/head.js:351:1 ... CommandChain.prototype.execute@http://mochi.test:8888/tests/dom/media/tests/mochitest/head.js:346:12 ... PeerConnectionTest.prototype.run@http://mochi.test:8888/tests/dom/media/tests/mochitest/pc.js:476:10 ... @http://mochi.test:8888/tests/dom/media/tests/mochitest/test_peerConnection_webAudio.html:38:3 ... runNetworkTest/</</<@http://mochi.test:8888/tests/dom/media/tests/mochitest/pc.js:1878:21 ... Promise*startNetworkAndTest@http://mochi.test:8888/tests/dom/media/tests/mochitest/network.js:102:1 ... runNetworkTest/</<@http://mochi.test:8888/tests/dom/media/tests/mochitest/pc.js:1877:7 ... runTestWhenReady/</<@http://mochi.test:8888/tests/dom/media/tests/mochitest/head.js:168:45 ... Promise*@http://mochi.test:8888/tests/dom/media/tests/mochitest/head.js:121:22 ... - expected PASS
23:30:34 INFO - 2131 INFO TEST-FAIL | dom/media/tests/mochitest/test_peerConnection_webAudio.html | The author of the test has indicated that flaky timeouts are expected. Reason: WebRTC inherently depends on timeouts
23:30:34 INFO - 2132 INFO Closing peer connections

Comment 1

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Right, .includes (Bug 1070767) is Nightly-only. Sorry I missed that. Andreas, can you uglify it?

Comment 2

[Andreas Pehrson [:pehrsons]]

Attachment: MozReview Request: bz://1157701/pehrsons

/r/7581 - Bug 1157701 - Remove usage of Array.prototype.includes() from test_peerConnection_replaceTrack.html. r=jib

Pull down this commit:

hg pull -r 46a06f79ac29f80fa534436579957b5f3134ab03 https://reviewboard-hg.mozilla.org/gecko/

Comment 3

[Andreas Pehrson [:pehrsons]]

Sorry for this. I didn't read the docs on includes() carefully enough.

Try for master: https://treeherder.mozilla.org/#/jobs?repo=try&revision=83d9ac54aafb
Try on top of aurora: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0276ae91f243

Comment 4

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8597039 [details]
MozReview Request: bz://1157701/pehrsons

https://reviewboard.mozilla.org/r/7579/#review6357

Ship It!

Comment 5

[Andreas Pehrson [:pehrsons]]

The test is not in M-e10s-2 on aurora it seems. Shouldn't make a difference though.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e8f02046fca6

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e8f02046fca6

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Still failing on a fresh set of simulation runs from today.

https://treeherder.mozilla.org/logviewer.html#?job_id=7013376&repo=try

2038 INFO TEST-UNEXPECTED-FAIL | dom/media/tests/mochitest/test_peerConnection_replaceTrack.html | Error in test execution: TypeError: inputSenderTracks.includes is not a function PeerConnectionWrapper.prototype.checkReceivingToneFrom/inputAudioStream</<@http://mochi.test:8888/tests/dom/media/tests/mochitest/pc.js:1549:47 ... PeerConnectionWrapper.prototype.checkReceivingToneFrom/inputAudioStream<@http://mochi.test:8888/tests/dom/media/tests/mochitest/pc.js:1549:18 ... PeerC

Comment 9

[Andreas Pehrson [:pehrsons]]

There is one use in pc.js as well. :|

But then how did my aurora run on try pass? I could of course have done something wrong with it...

Comment 10

[Andreas Pehrson [:pehrsons]]

dxr will help next time: https://dxr.mozilla.org/mozilla-central/search?q=includes%28+ext%3Ajs&case=true

Comment 11

[Andreas Pehrson [:pehrsons]]

Attachment: Properly remove usage of Array.prototype.includes()

try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1b1e6709bd63

Comment 12

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/20406039cdeb

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/20406039cdeb

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/20406039cdeb

Comment 16

[Andreas Pehrson [:pehrsons]]

Attachment: MozReview Request: Bug 1157701 - Remove usage of Array.prototype.includes() from test_peerConnection_replaceTrack.html. r=jib