Closed
Bug 1157702
Opened 11 years ago
Closed 11 years ago
Re-disable readinglist on mozilla-beta
Categories
(Firefox Graveyard :: Reading List, defect)
Tracking
(firefox38 unaffected, firefox38.0.5 fixed, firefox39 unaffected, firefox40 unaffected)
RESOLVED
FIXED
Firefox 38
| Tracking | Status | |
|---|---|---|
| firefox38 | --- | unaffected |
| firefox38.0.5 | --- | fixed |
| firefox39 | --- | unaffected |
| firefox40 | --- | unaffected |
People
(Reporter: Gijs, Assigned: Gijs)
References
Details
Attachments
(1 file)
|
6.70 KB,
patch
|
Dolske
:
review+
Dolske
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
So reading list and reader mode got disabled in bug 1155191.
Then bug 1157197 actually backed that out on mozilla-beta again so currently in the m-b repo, reading list has been re-enabled. It needs to be *off* for 38.0.5, so we should undo part of:
https://hg.mozilla.org/releases/mozilla-beta/rev/ceb1b9ba4a5a
| Assignee | ||
Comment 1•11 years ago
|
||
Dolske, can you check this is righteous? Doing a build as we speak to doublecheck as well...
Approval Request Comment
[Feature/regressing bug #]: bug 1157197 / bug 1155191
[User impact if declined]: we don't want reading list on 38.0.5
[Describe test coverage new/current, TreeHerder]: this patch messes with some tests. We've landed it before so it should be OK.
[Risks and why]: turning off features makes people sad. I think that about sums it up.
[String/UUID change made/needed]: no.
Attachment #8596576 -
Flags: review?(dolske)
Attachment #8596576 -
Flags: approval-mozilla-beta?
Updated•11 years ago
|
Attachment #8596576 -
Attachment is patch: true
Updated•11 years ago
|
Attachment #8596576 -
Flags: review?(dolske)
Attachment #8596576 -
Flags: review+
Attachment #8596576 -
Flags: approval-mozilla-beta?
Attachment #8596576 -
Flags: approval-mozilla-beta+
Comment 2•11 years ago
|
||
status-firefox38:
--- → fixed
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
status-firefox39:
--- → unaffected
status-firefox40:
--- → unaffected
Resolution: --- → FIXED
Target Milestone: --- → Firefox 38
Updated•11 years ago
|
status-firefox38.0.5:
--- → fixed
Updated•10 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•