1157716 - Mark unaccelerated antialiasing reftest failures on APZ as fuzzy

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect)

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: fix

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

I based this off two try runs:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a2f5d44cf8df
https://treeherder.mozilla.org/#/jobs?repo=try&revision=46e02e352b88

Doing a third now, so there might be a follow-up.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Might be worth seeing if these failures are cross-platform or not also.

Comment 4

[Markus Stange [:mstange]]

Comment on attachment 8596589 [details] [diff] [review]
fix

Please add an explanation in the commit message, something like this:

With APZ we always layerize the first scrollable element of the page, if the page itself is not scrollable. These additional layers can cause fuzzy reftest failures in two ways: By differences in blending, or by disabling sub-pixel text anti-aliasing. The latter is only a problem with unaccelerated drawing, because we don't support component alpha layers with BasicLayers. (We also don't support them with BasicCompositor, but "Reftest unaccelerated" tests BasicLayers and not BasicCompositor.)

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9e6906a839ea

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9e6906a839ea

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/447ab3513385

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/447ab3513385