1157737 - [meta] Username and password is not autofilled on sites with dynamically generated login forms

Status: RESOLVED FIXED

(Firefox for iOS :: Browser, defect)

Description

[Aaron Train [:aaronmt]]

https://instagram.com/accounts/login/

Login, save password, log-out, no autofill on the username/password field

Autofill is offered in Safari

Comment 1

[Aaron Train [:aaronmt]]

Not sure why this was minused. We have a remember password prompt that does nothing here.

Comment 2

[Richard Newman [:rnewman]]

Aaron, can you drive generalizing this?

Comment 3

[Richard Newman [:rnewman]]

We should see if WebKit gives us any help here.

Comment 4

[Stephan Leroux [:sleroux]]

Check to see if WebKit has some APIs/callbacks for seeing if password fields appear in the DOM.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Wasn't Emily working on this? Is there a WIP patch? Maybe we can improve things a little?

Comment 6

[Emily Toop (:fluffyemily)]

there is not WIP patch - for some reason I can't find the branch I was working on. I added some notes to https://bugzilla.mozilla.org/show_bug.cgi?id=1190992

Comment 7

[Emily Toop (:fluffyemily)]

Attachment: Pull request

Comment 8

[James Hugman [:jhugman] [@jhugman]]

Comment on attachment 8664287 [details] [review]
Pull request

Comments in PR.

Comment 9

[Emily Toop (:fluffyemily)]

Comment on attachment 8664287 [details] [review]
Pull request

I've updated this to reflect the convo around searching the mutations. Would like some feedback

Comment 10

[James Hugman [:jhugman] [@jhugman]]

Replied in PR. TL;DR the recursion/string matching isn't necessary at all; if a couple of assumptions are true then the code gets a lot simpler.