[meta] Username and password is not autofilled on sites with dynamically generated login forms

RESOLVED FIXED

Status

()

RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: aaronmt, Assigned: fluffyemily)

Tracking

(Depends on: 3 bugs, {meta})

unspecified
All
iOS
Dependency tree / graph

Firefox Tracking Flags

(fxios1.1+)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
https://instagram.com/accounts/login/

Login, save password, log-out, no autofill on the username/password field

Autofill is offered in Safari
tracking-fennec: ? → -
(Reporter)

Comment 1

3 years ago
Not sure why this was minused. We have a remember password prompt that does nothing here.
tracking-fennec: ? → ---
(Reporter)

Updated

3 years ago
tracking-fxios: --- → ?
tracking-fxios: ? → +
Component: General → Browser
Hardware: ARM → All
tracking-fxios: + → 1.1+
Aaron, can you drive generalizing this?
tracking-fxios: 1.1+ → +
OS: iOS 8 → iOS
Summary: Username and password is not autofilled on Instagram → Username and password is not autofilled on Instagram and other sites
Depends on: 1183257
Keywords: meta
Summary: Username and password is not autofilled on Instagram and other sites → [meta] Username and password is not autofilled on Instagram and other sites
Depends on: 1190992
(Reporter)

Updated

3 years ago
Depends on: 1195764
We should see if WebKit gives us any help here.
tracking-fxios: + → 1.1+
Summary: [meta] Username and password is not autofilled on Instagram and other sites → [meta] Username and password is not autofilled on sites with dynamically generated login forms
Check to see if WebKit has some APIs/callbacks for seeing if password fields appear in the DOM.
Wasn't Emily working on this? Is there a WIP patch? Maybe we can improve things a little?
Flags: needinfo?(etoop)
(Assignee)

Comment 6

3 years ago
there is not WIP patch - for some reason I can't find the branch I was working on. I added some notes to https://bugzilla.mozilla.org/show_bug.cgi?id=1190992
Flags: needinfo?(etoop)
(Assignee)

Updated

3 years ago
Assignee: nobody → etoop
(Assignee)

Updated

3 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 7

3 years ago
Created attachment 8664287 [details] [review]
Pull request
Attachment #8664287 - Flags: review?(jhugman)
Comment on attachment 8664287 [details] [review]
Pull request

Comments in PR.
Attachment #8664287 - Flags: review?(jhugman) → review+
(Assignee)

Comment 9

3 years ago
Comment on attachment 8664287 [details] [review]
Pull request

I've updated this to reflect the convo around searching the mutations. Would like some feedback
Attachment #8664287 - Flags: feedback?(jhugman)
Attachment #8664287 - Flags: feedback?(bnicholson)
(Assignee)

Updated

3 years ago
Attachment #8664287 - Flags: feedback?(bnicholson)
Replied in PR. TL;DR the recursion/string matching isn't necessary at all; if a couple of assumptions are true then the code gets a lot simpler.
Attachment #8664287 - Flags: review+
Attachment #8664287 - Flags: feedback?(jhugman)
(Assignee)

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Reporter)

Updated

3 years ago
Depends on: 1238098
You need to log in before you can comment on or make changes to this bug.